Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Job in index: Restore ability to update cluster state jobs #35539

Merged
merged 6 commits into from
Nov 14, 2018

Conversation

davidkyle
Copy link
Member

Feature branch PR.

In 6.6 and 6.7 jobs left open during upgrade will not be migrated and will continue to run with clusterstate configuration meaning the ability to update those jobs needs to be restored.

  • Restore FinalizeJobExecutionAction for cluster state jobs only
  • Restore JobManager updateJob() and revertSnapshot(). The approach here is to first look in the clusterstate for the job configuration then update the appropriate location

@davidkyle davidkyle added the :ml Machine learning label Nov 14, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkyle davidkyle mentioned this pull request Nov 14, 2018
43 tasks
@davidkyle davidkyle merged commit 0046d55 into elastic:feature-jindex-6x Nov 14, 2018
@davidkyle davidkyle deleted the clusterstate-updates branch November 14, 2018 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants