[CCR] Don't auto follow follow indices in the same cluster. #33944
Conversation
|
Pinging @elastic/es-distributed |
006313b to
006f583
Compare
There was a problem hiding this comment.
Thanks @martijnvg for fixing this :). I left a comment but I might be wrong.
| // that both leader and follow index are in the same cluster otherwise this can | ||
| // result into an index creation explosion. | ||
| if (leaderIndexMetaData.getCustomData(Ccr.CCR_CUSTOM_METADATA_KEY) != null && | ||
| leaderClusterState.getClusterName().equals(followerClusterState.getClusterName())) { |
There was a problem hiding this comment.
I am not sure if we should use the cluster name since the local and remote cluster can have the same name (I might be wrong here). Should we check if the cluster alias is "local"?
There was a problem hiding this comment.
I am not sure if we should use the cluster name since the local and remote cluster can have the same name (I might be wrong here).
True, that is possible, although I think must users would have different names for different clusters.
Should we check if the cluster alias is "local"?
Yes, I think that does the trick too and that is the actual scenario we do want the auto follow coordinator to not auto follow follower indices. I pushed this: df20939
…follow_indices_in_the_same_cluster
No description provided.