Configure test logging with Log4j 2 #20284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit configures test logging for Log4j 2. The default logger configuration uses the console appender but at the error level, so most tests are missing logging. Instead, this commit provides a configuration for tests which is picked up from the classpath by Log4j 2 when it initializes. However, this now means that we can no longer initialize Log4j with a bare-bones configuration when tests run as doing so will prevent Log4j 2 from attempting to configure logging via the classpath. Consequently, we move this needed initialization (as commented, to avoid a message about a status logger not being configured when we are preparing to configure Log4j from properties files in the config directory) to only run when we are explicitly configuring Log4j from properties files.
|
LGTM |
|
Tested in Eclipse and it works. Not sure I completely follow the change so feel free to get another reviewer if you want but LGTM what I can see |
* master: Elasticsearch 2.4.0 uses Lucene 5.5.2 settings: Make `action.auto_create_index` setting a dynamic cluster setting. Added version 2.4.0 with bwc indices Fix NPE when running a range query on a `scaled_float` with no upper bound. #20253 Optimize indexing for the autogenerated ID append-only case (#20211) Ensure ESTestCase is initialized before we run tests
|
Thanks for looking @nik9000 and @colings86. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit configures test logging for Log4j 2. The default logger
configuration uses the console appender but at the error level, so most
tests are missing logging. Instead, this commit provides a configuration
for tests which is picked up from the classpath by Log4j 2 when it
initializes. However, this now means that we can no longer initialize
Log4j with a bare-bones configuration when tests run as doing so will
prevent Log4j 2 from attempting to configure logging via the
classpath. Consequently, we move this needed initialization (as
commented, to avoid a message about a status logger not being configured
when we are preparing to configure Log4j from properties files in the
config directory) to only run when we are explicitly configuring Log4j
from properties files.
Relates #20235