Set an newly created IndexShard's ShardRouting before exposing it to operations #14918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…operations The work for elastic#10708 requires tighter integration with the current shard routing of a shard. As such, we need to make sure it is set before the IndexService exposes the shard to external operations.
| @@ -625,8 +625,7 @@ private void applyInitializingShard(final ClusterState state, final IndexMetaDat | |||
| if (logger.isDebugEnabled()) { | |||
| logger.debug("[{}][{}] creating shard", shardRouting.index(), shardId); | |||
| } | |||
| IndexShard indexShard = indexService.createShard(shardId, shardRouting); | |||
| indexShard.updateRoutingEntry(shardRouting, state.blocks().disableStatePersistence() == false); | |||
There was a problem hiding this comment.
Why is this not relevant anymore?
There was a problem hiding this comment.
it's done in the createShard call.
|
LGTM |
|
good, thanks! |
bleskes
added a commit
that referenced
this pull request
Nov 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The work for #10708 requires tighter integration with the current shard routing of a shard. As such, we need to make sure it is set before the IndexService exposes the shard to external operations.