Use min node version to guard injecting settings in logs provider #123005
+120
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kkrik-es, I've created a changelog YAML for you. |
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
This was referenced Feb 20, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
kkrik-es
added a commit
to kkrik-es/elasticsearch
that referenced
this pull request
Feb 20, 2025
…astic#123005) * Use min node version to guard injecting settings in logs provider * Update docs/changelog/123005.yaml * no random in cluster init
kkrik-es
added a commit
to kkrik-es/elasticsearch
that referenced
this pull request
Feb 20, 2025
…astic#123005) * Use min node version to guard injecting settings in logs provider * Update docs/changelog/123005.yaml * no random in cluster init
kkrik-es
added a commit
to kkrik-es/elasticsearch
that referenced
this pull request
Feb 20, 2025
…astic#123005) * Use min node version to guard injecting settings in logs provider * Update docs/changelog/123005.yaml * no random in cluster init
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
kkrik-es
added a commit
to kkrik-es/elasticsearch
that referenced
this pull request
Feb 20, 2025
…astic#123005) * Use min node version to guard injecting settings in logs provider * Update docs/changelog/123005.yaml * no random in cluster init (cherry picked from commit 5c12978) # Conflicts: # x-pack/plugin/logsdb/src/main/java/org/elasticsearch/xpack/logsdb/LogsDBPlugin.java # x-pack/plugin/logsdb/src/main/java/org/elasticsearch/xpack/logsdb/LogsdbIndexModeSettingsProvider.java # x-pack/plugin/logsdb/src/test/java/org/elasticsearch/xpack/logsdb/LogsdbIndexModeSettingsProviderTests.java # x-pack/plugin/logsdb/src/test/java/org/elasticsearch/xpack/logsdb/SyntheticSourceIndexSettingsProviderLegacyLicenseTests.java
kkrik-es
added a commit
that referenced
this pull request
Feb 20, 2025
…der (#123005) (#123051) * Use min node version to guard injecting settings in logs provider (#123005) * Use min node version to guard injecting settings in logs provider * Update docs/changelog/123005.yaml * no random in cluster init (cherry picked from commit 5c12978) # Conflicts: # x-pack/plugin/logsdb/src/main/java/org/elasticsearch/xpack/logsdb/LogsDBPlugin.java # x-pack/plugin/logsdb/src/main/java/org/elasticsearch/xpack/logsdb/LogsdbIndexModeSettingsProvider.java # x-pack/plugin/logsdb/src/test/java/org/elasticsearch/xpack/logsdb/LogsdbIndexModeSettingsProviderTests.java # x-pack/plugin/logsdb/src/test/java/org/elasticsearch/xpack/logsdb/SyntheticSourceIndexSettingsProviderLegacyLicenseTests.java * port fixes
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Feb 21, 2025
…astic#123005) * Use min node version to guard injecting settings in logs provider * Update docs/changelog/123005.yaml * no random in cluster init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logs index settings provider injects settings that were introduced in 8.17 and 8.18, so it may cause issues during rolling upgrades as some nodes may not be able to process the injected settings.
Fixes #122950