Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude (unused) snakeyaml dependency #120553

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

prdoyle
Copy link
Contributor

@prdoyle prdoyle commented Jan 21, 2025

Eliminate an unused library with a CVE. Succeeds in eliminating snakeyaml from the output of ./gradlew :x-pack:snapshot-tool:dependencies --configuration runtimeClasspath.

I ran :x-pack:snapshot-tool:qa:s3:check manually in IntelliJ and it passed.

See ES-10199

@prdoyle prdoyle added >non-issue :Core/Infra/Core Core issues without another label v7.17.28 labels Jan 21, 2025
@prdoyle prdoyle marked this pull request as ready for review January 21, 2025 21:39
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Jan 21, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@prdoyle prdoyle self-assigned this Jan 21, 2025
Copy link
Contributor

@jowiho jowiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@prdoyle prdoyle enabled auto-merge (squash) January 22, 2025 13:18
@prdoyle prdoyle merged commit ff9a1eb into elastic:7.17 Jan 22, 2025
10 checks passed
@prdoyle prdoyle deleted the exclude-snakeyaml branch January 22, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >non-issue Team:Core/Infra Meta label for core/infra team v7.17.28
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants