Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Ec2ImdsHttpHandler #119334

Merged
merged 5 commits into from
Dec 31, 2024
Merged

Enhance Ec2ImdsHttpHandler #119334

merged 5 commits into from
Dec 31, 2024

Conversation

DaveCTurner
Copy link
Contributor

  • Require IMDSv1 if using alternative endpoints (i.e. ECS)
  • Forbid profile name lookup with alternative endpoints
  • Add token TTL header for IMDSv2
  • Add support for instance-identity docs

@DaveCTurner
Enhance Ec2ImdsHttpHandler
6820bdf 
- Require IMDSv1 if using alternative endpoints (i.e. ECS)
- Forbid profile name lookup with alternative endpoints
- Add token TTL header for IMDSv2
- Add support for instance-identity docs
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs :Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure v9.0.0 v8.18.0 labels Dec 29, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label Dec 29, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

arteam
arteam approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@arteam arteam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner added auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Dec 31, 2024
@elasticsearchmachine elasticsearchmachine merged commit 34ec706 into elastic:main Dec 31, 2024
16 checks passed
@DaveCTurner DaveCTurner deleted the 2024/12/29/Ec2ImdsHttpHandler-enhancements branch December 31, 2024 10:24
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Dec 31, 2024
@DaveCTurner
Enhance Ec2ImdsHttpHandler (elastic#119334)
f3498b6 
- Require IMDSv1 if using alternative endpoints (i.e. ECS)
- Forbid profile name lookup with alternative endpoints
- Add token TTL header for IMDSv2
- Add support for instance-identity docs
@DaveCTurner DaveCTurner mentioned this pull request Dec 31, 2024
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.x

elasticsearchmachine pushed a commit that referenced this pull request Dec 31, 2024
@DaveCTurner
Enhance Ec2ImdsHttpHandler (#119334) (#119383)
3fe7637 
- Require IMDSv1 if using alternative endpoints (i.e. ECS)
- Forbid profile name lookup with alternative endpoints
- Add token TTL header for IMDSv2
- Add support for instance-identity docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arteam arteam arteam approved these changes

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed Coordination Meta label for Distributed Coordination team >test Issues or PRs that are addressing/adding tests v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaveCTurner @elasticsearchmachine @arteam