ESQL: Fix EsqlSecurityIT LOOKUP tests not checking snapshot #119283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
approved these changes
Dec 26, 2024
|
@nik9000 Just added the capability checks instead. Also added esql-core and esql as dependencies to the project for it to work |
nik9000
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
That's fine. You could have done the capability check over REST too, which is how the yaml tests work. They really are all fine.
If you have a mixed version cluster here then doing the capability tests over REST is great because it'll properly make sure all nodes have it.
💚 Backport successful
|
ivancea
added a commit
to ivancea/elasticsearch
that referenced
this pull request
Dec 30, 2024
…119283) Without the snapshot check, the periodic tests were failing. Fixes elastic#119268 Fixes elastic#119269 Fixes elastic#119270 Fixes elastic#119271
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 30, 2024
ivancea
added a commit
that referenced
this pull request
Dec 31, 2024
ivancea
pushed a commit
that referenced
this pull request
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the snapshot check, the periodic tests were failing.
Fixes #119268
Fixes #119269
Fixes #119270
Fixes #119271