-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove min_read_only_index_version from XContent node #119083
Merged
elasticsearchmachine
merged 3 commits into
elastic:main
from
tlrx:2024/12/19/remove-min-read-only-index-version-from-xcontent
Dec 19, 2024
Merged
Remove min_read_only_index_version from XContent node #119083
elasticsearchmachine
merged 3 commits into
elastic:main
from
tlrx:2024/12/19/remove-min-read-only-index-version-from-xcontent
Dec 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We prefer to remove this information from the API since they are not useful externally, impact the search shard API and may be removed later (which would be a breaking change). Follow-up elastic#118744
tlrx
added
>non-issue
:Distributed Coordination/Cluster Coordination
Cluster formation and cluster state publication, including cluster membership and fault detection.
v9.0.0
v8.18.0
labels
Dec 19, 2024
elasticsearchmachine
added
the
Team:Distributed Coordination
Meta label for Distributed Coordination team
label
Dec 19, 2024
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
henningandersen
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
tlrx
added
the
auto-backport
Automatically create backport pull requests when merged
label
Dec 19, 2024
tlrx
added
the
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
label
Dec 19, 2024
tlrx
deleted the
2024/12/19/remove-min-read-only-index-version-from-xcontent
branch
December 19, 2024 16:40
💚 Backport successful
|
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Dec 19, 2024
We prefer to remove this information from the API since they are not useful externally, impact the search shard API and may be removed later (which would be a breaking change). Follow-up elastic#118744
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Dec 19, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 19, 2024
navarone-feekery
pushed a commit
to navarone-feekery/elasticsearch
that referenced
this pull request
Dec 26, 2024
We prefer to remove this information from the API since they are not useful externally, impact the search shard API and may be removed later (which would be a breaking change). Follow-up elastic#118744
navarone-feekery
pushed a commit
to navarone-feekery/elasticsearch
that referenced
this pull request
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Distributed Coordination/Cluster Coordination
Cluster formation and cluster state publication, including cluster membership and fault detection.
>non-issue
Team:Distributed Coordination
Meta label for Distributed Coordination team
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We prefer to remove this information from the API since they are not useful externally, impact the search shard API and may be removed later (which would be a breaking change).
Follow-up #118744