Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove min_read_only_index_version from XContent node #119083

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Dec 19, 2024

We prefer to remove this information from the API since they are not useful externally, impact the search shard API and may be removed later (which would be a breaking change).

Follow-up #118744

We prefer to remove this information from the API since they
are not useful externally, impact the search shard API and
may be removed later (which would be a breaking change).

Follow-up elastic#118744
@tlrx tlrx added >non-issue :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. v9.0.0 v8.18.0 labels Dec 19, 2024
@tlrx tlrx marked this pull request as ready for review December 19, 2024 13:53
@tlrx tlrx requested a review from henningandersen December 19, 2024 13:53
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label Dec 19, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tlrx tlrx added the auto-backport Automatically create backport pull requests when merged label Dec 19, 2024
@tlrx tlrx added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Dec 19, 2024
@elasticsearchmachine elasticsearchmachine merged commit 77eb191 into elastic:main Dec 19, 2024
16 checks passed
@tlrx tlrx deleted the 2024/12/19/remove-min-read-only-index-version-from-xcontent branch December 19, 2024 16:40
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

tlrx added a commit to tlrx/elasticsearch that referenced this pull request Dec 19, 2024
We prefer to remove this information from the API since they are not
useful externally, impact the search shard API and may be removed later
(which would be a breaking change).

Follow-up elastic#118744
tlrx added a commit to tlrx/elasticsearch that referenced this pull request Dec 19, 2024
elasticsearchmachine pushed a commit that referenced this pull request Dec 19, 2024
…#119114)

* Remove min_read_only_index_version from XContent node (#119083)

We prefer to remove this information from the API since they are not
useful externally, impact the search shard API and may be removed later
(which would be a breaking change).

Follow-up #118744

* fix
navarone-feekery pushed a commit to navarone-feekery/elasticsearch that referenced this pull request Dec 26, 2024
We prefer to remove this information from the API since they are not
useful externally, impact the search shard API and may be removed later
(which would be a breaking change).

Follow-up elastic#118744
navarone-feekery pushed a commit to navarone-feekery/elasticsearch that referenced this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >non-issue Team:Distributed Coordination Meta label for Distributed Coordination team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants