ES|QL: Fix RLIKE folding with (unsupported) case insensitive pattern #118454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @luigidellaquila, I've created a changelog YAML for you. |
luigidellaquila
commented
Dec 16, 2024
| @@ -93,6 +93,11 @@ protected TypeResolution resolveType() { | |||
| return isString(field(), sourceText(), DEFAULT); | |||
| } | |||
|
|
|||
| @Override | |||
| public Boolean fold() { | |||
| return (Boolean) EvaluatorMapper.super.fold(); | |||
There was a problem hiding this comment.
This is the actual fix, all the rest is refactoring and code cleanup
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Dec 16, 2024
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 16, 2024
nik9000
pushed a commit
to nik9000/elasticsearch
that referenced
this pull request
Dec 26, 2024
nik9000
pushed a commit
to nik9000/elasticsearch
that referenced
this pull request
Dec 26, 2024
|
I'm also backporting to 8.17.1: #119292 |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 26, 2024
|
Thanks @nik9000! |
Happy to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RLIKE with
(?i)prefix (case-insensitive) is not supported in ES|QL, but in a specific case (constant folding) the calculation relied on Java regex, that actually supports it, making the overall behavior inconsistent.With this fix,
(?i)prefix is not taken into consideration as a case-insensitive option.Taking a chance to cleanup a bit the
RegexMatchoperator hierarchy.Fixes: #118371