[Build] Fix build finished hooks on ci when using configuration cache #116888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-delivery (Team:Delivery) |
|
This was hidden from signaling a failure as it happened in the build finished hook after the build is already marked as successful. But it showed in the logs here https://buildkite.com/elastic/elasticsearch-gradle-cache-validation/builds/68#01932b58-cfe0-4d08-ab8c-1153cbe88f24 |
jozala
approved these changes
Nov 18, 2024
salvatore-campagna
pushed a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Nov 18, 2024
elastic#116888) Fixes two incompatibilities with Gradle configuration cache in our build scan build finished hook: referencing static methods from build script referencing gradle object from closure
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
elastic#116888) Fixes two incompatibilities with Gradle configuration cache in our build scan build finished hook: referencing static methods from build script referencing gradle object from closure
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Feb 17, 2025
elastic#116888) Fixes two incompatibilities with Gradle configuration cache in our build scan build finished hook: referencing static methods from build script referencing gradle object from closure (cherry picked from commit 929d398)
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Feb 17, 2025
elastic#116888) Fixes two incompatibilities with Gradle configuration cache in our build scan build finished hook: referencing static methods from build script referencing gradle object from closure (cherry picked from commit 929d398)
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Feb 17, 2025
elastic#116888) Fixes two incompatibilities with Gradle configuration cache in our build scan build finished hook: referencing static methods from build script referencing gradle object from closure (cherry picked from commit 929d398) # Conflicts: # build-tools-internal/src/main/groovy/elasticsearch.build-scan.gradle
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
breskeby
added a commit
that referenced
this pull request
Feb 18, 2025
…on cache (#116888) (#122744) * [Gradle] Fix build finished hooks on ci when using configuration cache (#116888) Fixes two incompatibilities with Gradle configuration cache in our build scan build finished hook: referencing static methods from build script referencing gradle object from closure (cherry picked from commit 929d398) # Conflicts: # build-tools-internal/src/main/groovy/elasticsearch.build-scan.gradle * Update elasticsearch.build-scan.gradle fix license * Fix license header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two incompatibilities with Gradle configuration cache in our build scan build finished hook: