Always check the parent breaker with zero bytes in PreallocatedCircuitBreakerService #115181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @iverase, I've created a changelog YAML for you. |
nik9000
approved these changes
Oct 21, 2024
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Oct 21, 2024
…tBreakerService (elastic#115181) PreallocatedCircuitBreakerService will call the parent breaker if the nunber of bytes passed is zero.
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Oct 21, 2024
…tBreakerService (elastic#115181) PreallocatedCircuitBreakerService will call the parent breaker if the nunber of bytes passed is zero.
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Oct 21, 2024
…tBreakerService (elastic#115181) PreallocatedCircuitBreakerService will call the parent breaker if the nunber of bytes passed is zero.
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 25, 2024
…tBreakerService (elastic#115181) PreallocatedCircuitBreakerService will call the parent breaker if the nunber of bytes passed is zero.
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
…tBreakerService (elastic#115181) PreallocatedCircuitBreakerService will call the parent breaker if the nunber of bytes passed is zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the bytes passed to the PreallocatedCircuitBreakerService is zero, we really want to check the real memory circuit breaker. Still this service only calls the parent if the buffer has been filled, going against the intention of the check. Therefore let's add the logic to call the parent if the provided bytes are zero.
relates #114941