-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inference autoscaling telemetry #110630
Inference autoscaling telemetry #110630
Conversation
Pinging @elastic/ml-core (Team:ML) |
Hi @jan-elastic, I've created a changelog YAML for you. |
...g/elasticsearch/xpack/ml/inference/adaptiveallocations/AdaptiveAllocationsScalerService.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is something a broader team would like to discuss hence pinging @elastic/es-core-infra
My main worry would be if we want to change the signature of the methods to accept the collection of attributes or have a variant of methods
Thanks for bringing them in the loop. Note that the signatures of the public-facing methods (like Regarding the internal methods (like |
…e-autoscaling-telemetry
@pgomulka @elastic/es-core-infra Could you have a look at this PR? If possible, I'd like to wrap this up this week before I go on holiday. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, for the delay on this @jan-elastic!
We've just discussed your addition to the metrics interface in core/infra, that part looks good to us 👍 Thanks for the contribution :)
Thanks for the review! |
The support is needed for RecordingInstruments to be used in tests for guages with a collection of observers. Relates: elastic#110630
) The support is needed for RecordingInstruments to be used in tests for guages with a collection of observers. Relates: #110630
…tic#112195) The support is needed for RecordingInstruments to be used in tests for guages with a collection of observers. Relates: elastic#110630
This PR add telemetry for inference adaptive autoscaling.
This feature needs gauge metrics labeled by deployment_id, comparable to the examples listed here:
https://opentelemetry.io/docs/specs/otel/metrics/api/#asynchronous-gauge-creation
Unfortunately, the existing telemetry framework in ES for gauges only allows single values, therefore I had to extend it.