Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inference autoscaling telemetry #110630

Merged
merged 6 commits into from
Jul 29, 2024
Merged

Conversation

jan-elastic
Copy link
Contributor

@jan-elastic jan-elastic commented Jul 9, 2024

This PR add telemetry for inference adaptive autoscaling.

This feature needs gauge metrics labeled by deployment_id, comparable to the examples listed here:
https://opentelemetry.io/docs/specs/otel/metrics/api/#asynchronous-gauge-creation

Unfortunately, the existing telemetry framework in ES for gauges only allows single values, therefore I had to extend it.

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v8.16.0 labels Jul 9, 2024
@jan-elastic jan-elastic added >feature :ml Machine learning Team:ML Meta label for the ML team cloud-deploy Publish cloud docker image for Cloud-First-Testing labels Jul 9, 2024
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Jul 9, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine
Copy link
Collaborator

Hi @jan-elastic, I've created a changelog YAML for you.

@jan-elastic jan-elastic requested review from davidkyle and pgomulka July 9, 2024 11:10
@pgomulka pgomulka requested a review from a team July 11, 2024 10:17
Copy link
Contributor

@pgomulka pgomulka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is something a broader team would like to discuss hence pinging @elastic/es-core-infra
My main worry would be if we want to change the signature of the methods to accept the collection of attributes or have a variant of methods

@pgomulka pgomulka requested a review from a team July 11, 2024 10:19
@jan-elastic
Copy link
Contributor Author

I think this is something a broader team would like to discuss hence pinging @elastic/es-core-infra My main worry would be if we want to change the signature of the methods to accept the collection of attributes or have a variant of methods

Thanks for bringing them in the loop.

Note that the signatures of the public-facing methods (like registerDoubleGauge) have not changed, and I've added variants (like registerDoublesGauge (plural)).

Regarding the internal methods (like DoubleAsyncCounterAdapter), I think the current approach leads to less code duplication without disadvantages, but I'll leave that decision up to the @elastic/es-core-infra team.

@jan-elastic
Copy link
Contributor Author

@pgomulka @elastic/es-core-infra Could you have a look at this PR? If possible, I'd like to wrap this up this week before I go on holiday. Thanks!

Copy link
Contributor

@mosche mosche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, for the delay on this @jan-elastic!
We've just discussed your addition to the metrics interface in core/infra, that part looks good to us 👍 Thanks for the contribution :)

@jan-elastic jan-elastic requested a review from davidkyle July 29, 2024 08:36
@jan-elastic
Copy link
Contributor Author

Thanks for the review!

@jan-elastic jan-elastic merged commit 26623f1 into main Jul 29, 2024
17 checks passed
@jan-elastic jan-elastic deleted the inference-autoscaling-telemetry branch July 29, 2024 08:38
ywangd added a commit to ywangd/elasticsearch that referenced this pull request Aug 26, 2024
The support is needed for RecordingInstruments to be used in tests for
guages with a collection of observers.

Relates: elastic#110630
elasticsearchmachine pushed a commit that referenced this pull request Aug 27, 2024
)

The support is needed for RecordingInstruments to be used in tests for
guages with a collection of observers.

Relates: #110630
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this pull request Sep 4, 2024
…tic#112195)

The support is needed for RecordingInstruments to be used in tests for
guages with a collection of observers.

Relates: elastic#110630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloud-deploy Publish cloud docker image for Cloud-First-Testing >feature :ml Machine learning Team:ML Meta label for the ML team v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants