Increase probability of synthetic source tests using ignore_malformed #109711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
dnhatn
approved these changes
Jun 13, 2024
| @@ -1268,6 +1267,11 @@ public final void testSyntheticEmptyList() throws IOException { | |||
| assertThat(syntheticSource(mapper, b -> b.startArray("field").endArray()), equalTo(expected)); | |||
| } | |||
|
|
|||
| private boolean shouldUseIgnoreMalformed() { | |||
| // 5% of test runs use ignore_malformed | |||
| return supportsIgnoreMalformed() && randomDouble() >= 0.05; | |||
There was a problem hiding this comment.
Wow, of course. I guess it's a good stress test to run this on CI :)
|
@elasticmachine update branch |
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scope of ongoing work on
ignore_malformedsupport in synthetic source (#106483) i noticed thatrarely()used in synthetic source tests to determine application ofignore_malformedis indeed very rare. Based on my testing it has a probability significantly lower than 1%. Given that a lot of fields now have support for malformed values in synthetic source it seems reasonable to exercise this code more often. This PR changes the logic to applyignore_malformedin 5% of tests.