-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding aggregations support for the _ignored
field
#101373
Merged
salvatore-campagna
merged 123 commits into
elastic:main
from
eyalkoren:ignore_field_aggs
Apr 29, 2024
+867
−34
Merged
Changes from 1 commit
Commits
Show all changes
123 commits
Select commit
Hold shift + click to select a range
50d1ffb
Adding aggregations support for the _ignored field
eyalkoren 737fbb2
Update docs/changelog/101373.yaml
eyalkoren ace155a
spotless
eyalkoren e698cc1
Merge remote-tracking branch 'eyalkoren/ignore_field_aggs' into ignor…
eyalkoren 5e3f6ec
Adjust tests
eyalkoren ef9ce62
Merge remote-tracking branch 'upstream/main' into ignore_field_aggs
eyalkoren c34dc4b
Add exists query using doc_values
eyalkoren aa9cdec
Improve error message for unsupported aggs
eyalkoren 2e03324
ohh come on
eyalkoren 8bc6582
Merge remote-tracking branch 'upstream/main' into ignore_field_aggs
eyalkoren 873a34f
WIP: making field not stored
eyalkoren 904694b
Merge branch 'main' into ignore_field_aggs
salvatore-campagna aba9ff6
fix: _ignored field in meta field list
salvatore-campagna a316a4d
fix: make _ignored field stored
salvatore-campagna f6c4ad2
fix: do not use a mock for SearchExecutionContext
salvatore-campagna 53d374e
fix: decrement reference count for response objects
salvatore-campagna f78532d
fix: include a new sub-fetch phase fetching the _ignored field from d…
salvatore-campagna 1256646
fix: index the _ignored field
salvatore-campagna 47cf96a
fix: remove fetch phase if stored fields are disabled
salvatore-campagna 3c5d42e
fix: introduce the new phase in yaml tests
salvatore-campagna fea357c
Merge branch 'main' into ignore_field_aggs
salvatore-campagna 6e80788
fix: include _ignored field as stored for backward compatibility
salvatore-campagna 866c8f4
fix: a few review comments
salvatore-campagna 667972d
fix: a couple more tests
salvatore-campagna b91b8ca
fix: a few more tests
salvatore-campagna df3a45a
remove assertion which is version dependent
salvatore-campagna 49a77e9
fix: update skip version
salvatore-campagna d52e5e4
fix: _ignored field does not have terms vector anymore since it is no…
salvatore-campagna bc894bb
fix: release response objects
salvatore-campagna e5a0743
fix: do not rely on order which is lost with doc values
salvatore-campagna fb8263c
fix: try to release again everything
salvatore-campagna 664958d
test: restore test checking term vectors for the _ignored field
salvatore-campagna 77f2e3b
fix: remove loading on meta fields from StoredFieldsPhase
salvatore-campagna 1bae37a
fix: remove FetchIgnoredMetadataPhase and use FetchFieldsFetcher for …
salvatore-campagna 171c7ad
fix: remove FetchIgnoredMetadataPhase
salvatore-campagna 8bcfe85
fix: do not include unmapped fields
salvatore-campagna 4096422
fix: FetchFieldsPhase always executed to fetch metadata fields
salvatore-campagna 189f6ee
fix: evoid creation of empty list
salvatore-campagna 2f62882
fix: move metadata fields to MetadataFetcher
salvatore-campagna 5b2207c
fix: remove unused class
salvatore-campagna eca3e1b
fix: do not lead stored fields if not required
salvatore-campagna 300c342
fix: test terms aggregation on _ignored field
salvatore-campagna 9b33013
fix: forgot to make the field not stored
salvatore-campagna 43a5d61
fix: prevent NPE when storedFieldsContext is null
salvatore-campagna 238473e
test: include a few more aggregation tests
salvatore-campagna 0344e28
fix: remove existsQuery from legacy ignored field type
salvatore-campagna 4a233df
refactor: use ValueFetcher in innerGetFetch
salvatore-campagna f904250
Revert "refactor: use ValueFetcher in innerGetFetch"
salvatore-campagna 05f7553
fix: ignore term vectors generation for the _ignored field
salvatore-campagna 6f9f878
docs: update version
salvatore-campagna bc6aa30
fix: return _size only if required
salvatore-campagna c725fb1
test: update skip version
salvatore-campagna bf9629d
Merge branch 'main' into ignore_field_aggs
salvatore-campagna bcf16a3
fix: include a mixed cluster test
salvatore-campagna e31df96
fix: increase health check timeout
salvatore-campagna 05fefdf
fix: expect two documents to be indexed
salvatore-campagna bbdc263
fix: yaml test skip version and additional phase
salvatore-campagna bfe6913
fix: phase name in yaml test
salvatore-campagna 509abe5
fix: include logic to deal with backward compatibility
salvatore-campagna 763fc27
refactor: mixed cluster test with exists and aggregation
salvatore-campagna 390fc6b
comment: move it to the right if branch
salvatore-campagna be24d84
fix: null pointer exception
salvatore-campagna 1c620ea
fix: icnlude index settings and created version in mock
salvatore-campagna e402020
fix: icnlude index settings and created version in mock
salvatore-campagna a9bd6cd
fix: 8.14 bwc test
salvatore-campagna 1a34860
fix: incorrect index usage
salvatore-campagna 52c326a
fix: mixed cluster test check on old index version
salvatore-campagna de91ea6
fix: restore value of DUMP_OUTPUT_ON_FAILURE_PROP_NAME
salvatore-campagna 4a3b4c2
fix: ESSingleNodeTestCase instead of ESIntegTestCase
salvatore-campagna 05a8c5f
fix: move test from IgnoreFieldIT to IgnoredFieldTypeTests
salvatore-campagna 4657791
test: ignore field type selection logic
salvatore-campagna 656534a
fix: use correct type depending on version
salvatore-campagna e1abe80
fix null pointer exception
salvatore-campagna 773b0a6
fix: use parent exists query implementation
salvatore-campagna 72f6465
fix: remove incorrect null check
salvatore-campagna d1c0cbe
fix: read _ignored field from stored field for indices created before…
salvatore-campagna 154682b
fix: simplify bwc compatibility
salvatore-campagna 92c06ff
fix: exists query and metadata stored field condition
salvatore-campagna c30c246
fix: do not skip metadata fields
salvatore-campagna 1f86317
nit: avoid using a temporary variable
salvatore-campagna 1c80140
fix: exclude meta fields when stored_fields = none
salvatore-campagna 85e1ba7
fix: exclude metadata fields handled by MetadataFetcher
salvatore-campagna 570fe56
fix: undo fetch of stored fields
salvatore-campagna 8acc8b1
test: _ignored field upgrade test
salvatore-campagna 55e3d4d
fix: include the _ignored stored field for old indices
salvatore-campagna c01f2dd
Merge branch 'main' into ignore_field_aggs
salvatore-campagna ee51ec8
fix: address review comments
salvatore-campagna 7444215
refactor: metadata fields fetching logic and test
salvatore-campagna bcc1adf
fix: IgnoredFieldMixedClusterUpgradeIT
salvatore-campagna 17996be
Merge branch 'main' into ignore_field_aggs
salvatore-campagna c2232c9
fix: restore original after merging #106325
salvatore-campagna 98d3856
fix: restore original test outcome
salvatore-campagna e27bf2e
fix: makre sure we get both old and new documents including _ignored …
salvatore-campagna 9846d32
fix: execute rolling upgrade test only if _ignored is stored in old v…
salvatore-campagna cee180a
fix: update skip version as of removing stored field for _ignored
salvatore-campagna eee62f1
fix: skip version and get _ignored
salvatore-campagna cfc94a2
fix: review comments
salvatore-campagna c6f4164
fix: update rolling upgrade tests
salvatore-campagna dc3ce8e
fix: update skip version after switching to 8.15
salvatore-campagna 9c56f59
fix: undo dec ref changes
salvatore-campagna 52f1ef3
fix: review comments
salvatore-campagna 4609a42
Merge branch 'main' into ignore_field_aggs
salvatore-campagna 80a7426
fix: use public version string
salvatore-campagna ea20632
fix: remove test for term vectors
salvatore-campagna 2ac32f4
docs: update version
salvatore-campagna 3ce075f
fix: update version in reason
salvatore-campagna f669f9e
fix: remove tests included in another class
salvatore-campagna 58bb648
fix: error message and _ignored debug stored field
salvatore-campagna 08dd66f
fix: remove _ignored
salvatore-campagna b561aab
fix: remove SuppressWarnings
salvatore-campagna 98a4c6b
fix: remove _ignored
salvatore-campagna 897eca0
fix: error message in bwc test
salvatore-campagna 241a8ca
fix: fetch _ignored field from doc values
salvatore-campagna cf06f0c
fix: undo unecessary change
salvatore-campagna 4f1816d
fix: non-null ingored fields after implementing fetch from doc values
salvatore-campagna 3276a82
Merge branch 'main' into ignore_field_aggs
salvatore-campagna 6825ada
Revert "fix: remove test for term vectors"
salvatore-campagna fe0d874
fix: load _ignored from stored field or from doc values
salvatore-campagna de02373
fix: re-enable terms vector test
salvatore-campagna 1175322
Merge branch 'main' into ignore_field_aggs
salvatore-campagna e37e1b9
fix: update skip version
salvatore-campagna bfec2b3
Merge branch 'main' into ignore_field_aggs
salvatore-campagna 4f95463
Merge branch 'main' into ignore_field_aggs
salvatore-campagna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 2 additions & 3 deletions
5
...-api-spec/src/yamlRestTest/resources/rest-api-spec/test/get/120_stored_fields_ignored.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not rerturned anymore because the field is not stored anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that makes sense, I was expecting this change.