Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] ApiKeyServiceTests testGetApiKeyMetadata failing #86211

Closed
breskeby opened this issue Apr 27, 2022 · 2 comments · Fixed by #86218
Closed

[CI] ApiKeyServiceTests testGetApiKeyMetadata failing #86211

breskeby opened this issue Apr 27, 2022 · 2 comments · Fixed by #86218
Assignees
@ywangd
Labels
:Security/Security Security issues without another label Team:Security Meta label for security team >test-failure Triaged test failures from CI

Comments

@breskeby
Copy link
Contributor

Is this potentially related to this recent change in that area done in #86054 ?

Build scan:
https://gradle-enterprise.elastic.co/s/azmukpqpbn4yq/tests/:x-pack:plugin:security:test/org.elasticsearch.xpack.security.authc.ApiKeyServiceTests/testGetApiKeyMetadata

Reproduction line:
./gradlew ':x-pack:plugin:security:test' --tests "org.elasticsearch.xpack.security.authc.ApiKeyServiceTests.testGetApiKeyMetadata" -Dtests.seed=F333870E25DA21A1 -Dtests.locale=zh-Hans-CN -Dtests.timezone=America/Porto_Velho -Druntime.java=17

Applicable branches:
master

Reproduces locally?:
Yes

Failure history:
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.xpack.security.authc.ApiKeyServiceTests&tests.test=testGetApiKeyMetadata

Failure excerpt:

java.lang.AssertionError: 
Expected: a map with size <0>
     but: map size was <4>

  at __randomizedtesting.SeedInfo.seed([F333870E25DA21A1:141EE9790AB7BA34]:0)
  at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
  at org.junit.Assert.assertThat(Assert.java:956)
  at org.junit.Assert.assertThat(Assert.java:923)
  at org.elasticsearch.xpack.security.authc.ApiKeyServiceTests.testGetApiKeyMetadata(ApiKeyServiceTests.java:1694)
  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(NativeMethodAccessorImpl.java:-2)
  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  at java.lang.reflect.Method.invoke(Method.java:568)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:44)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:375)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:824)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:475)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:375)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:831)
  at java.lang.Thread.run(Thread.java:833)
@breskeby breskeby added :Security/Security Security issues without another label >test-failure Triaged test failures from CI labels Apr 27, 2022
@elasticmachine elasticmachine added the Team:Security Meta label for security team label Apr 27, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@ywangd ywangd self-assigned this Apr 27, 2022
@breskeby breskeby mentioned this issue Apr 27, 2022
Merged
breskeby added a commit to breskeby/elasticsearch that referenced this issue Apr 27, 2022
@breskeby
[Test] Mute ApiKeyServiceTests#testGetApiKeyMetadata
9ae94ed 
see elastic#86211 for details
elasticsearchmachine pushed a commit that referenced this issue Apr 27, 2022
@breskeby
[Test] Mute ApiKeyServiceTests#testGetApiKeyMetadata (#86212)
339d281 
see #86211 for details
@ywangd
Copy link
Member

ywangd commented Apr 27, 2022

Another refactor fallout, I'll raise a fix.

ywangd added a commit to ywangd/elasticsearch that referenced this issue Apr 27, 2022
@ywangd
[Test] Ensure correct randomization for API key metadata
d042676 
Similar to elastic#86188, the test failure elastic#86211 is caused by incorrect
randomziation. In this case, the API metadata was expected to be null
in some cases. This PR fixes it by ensuring the correct randomisation.

Resolves: elastic#86211
@ywangd ywangd mentioned this issue Apr 27, 2022
Merged
elasticsearchmachine pushed a commit that referenced this issue Apr 27, 2022
@ywangd
[Test] Ensure correct randomization for API key metadata (#86218)
ea07e9d 
Similar to #86188, the test failure #86211 is also caused by incorrect
randomziation due to refactoring.  In this case, the API metadata was
expected to be null in some cases.  This PR fixes it by ensuring the
correct randomisation.

Resolves: #86211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ywangd ywangd

Labels
:Security/Security Security issues without another label Team:Security Meta label for security team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Test] Ensure correct randomization for API key metadata ywangd/elasticsearch
3 participants
@breskeby @ywangd @elasticmachine