Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] TimeSeriesLifecycleActionsIT testWaitForSnapshot failure #50781

Closed
martijnvg opened this issue Jan 9, 2020 · 14 comments
Closed

[CI] TimeSeriesLifecycleActionsIT testWaitForSnapshot failure #50781

martijnvg opened this issue Jan 9, 2020 · 14 comments
Assignees
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >test-failure Triaged test failures from CI

Comments

@martijnvg
Copy link
Member

Failure:

2> java.lang.AssertionError: 
    Expected: "completed"
         but: was "wait_for_snapshot"
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:956)
        at org.junit.Assert.assertThat(Assert.java:923)
        at org.elasticsearch.xpack.ilm.TimeSeriesLifecycleActionsIT.lambda$testWaitForSnapshot$23(TimeSeriesLifecycleActionsIT.java:344)
        at org.elasticsearch.test.ESTestCase.assertBusy(ESTestCase.java:879)
        at org.elasticsearch.test.ESTestCase.assertBusy(ESTestCase.java:852)
        at org.elasticsearch.xpack.ilm.TimeSeriesLifecycleActionsIT.testWaitForSnapshot(TimeSeriesLifecycleActionsIT.java:344)

Reproduce line:

./gradlew ':x-pack:plugin:ilm:qa:multi-node:integTestRunner' --tests "org.elasticsearch.xpack.ilm.TimeSeriesLifecycleActionsIT.testWaitForSnapshot" -Dtests.seed=EC28318704EF9660 -Dtests.security.manager=true -Dtests.locale=nb -Dtests.timezone=Pacific/Tarawa -Dcompiler.java=13

This didn't reproduce for me.

Build url: https://gradle-enterprise.elastic.co/s/uirpg2i73okrq

This test failed a few times already:
https://build-stats.elastic.co/app/kibana#/discover?_g=(refreshInterval:(pause:!t,value:0),time:(from:now-30d,mode:quick,to:now))&_a=(columns:!(_source),index:e58bf320-7efd-11e8-bf69-63c8ef516157,interval:auto,query:(language:lucene,query:'class:*TimeSeriesLifecycleActionsIT+AND+test:testWaitForSnapshot'),sort:!(time,desc))

@martijnvg martijnvg added >test-failure Triaged test failures from CI :Data Management/ILM+SLM Index and Snapshot lifecycle management labels Jan 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Jan 9, 2020
original-brownbear added a commit that referenced this issue Jan 9, 2020
@original-brownbear
Copy link
Member

Muted in 170e100

@original-brownbear
Copy link
Member

This looks like the same issue in testWaitForSnapshotSlmExecutedBefore https://gradle-enterprise.elastic.co/s/t65m4uewdrzlo

@nik9000
Copy link
Member

nik9000 commented Jan 9, 2020

This showed up with #50454

probakowski added a commit to probakowski/elasticsearch that referenced this issue Jan 9, 2020
This change adds some randomness and cleanup step to TimeSeriesLifecycleActionsIT#testWaitForSnapshot and testWaitForSnapshotSlmExecutedBefore tests in attempt to make them stable.

Reletes to elastic#50781
@mark-vieira
Copy link
Contributor

Let's please give this some immediate attention. TimeSeriesLifecycleActionsIT is the most common test failure across CI in the past month excluding Windows packaging tests. That could just mean muting for now.

probakowski added a commit to probakowski/elasticsearch that referenced this issue Jan 10, 2020
Muting the test while I work on fixing its flakiness.
Relates elastic#50781
probakowski added a commit that referenced this issue Jan 10, 2020
#50842)

Muting the test while I work on fixing its flakiness.
Relates #50781
@probakowski
Copy link
Contributor

testWaitForSnapshotSlmExecutedBefore muted in ce50e8e

probakowski added a commit to probakowski/elasticsearch that referenced this issue Jan 13, 2020
This change adds some randomness and cleanup step to TimeSeriesLifecycleActionsIT#testWaitForSnapshot and testWaitForSnapshotSlmExecutedBefore tests in attempt to make them stable.

Reletes to elastic#50781
probakowski added a commit that referenced this issue Jan 14, 2020
… and testWaitForSnapshotSlmExecutedBefore test (#50818)

* Fix flaky TimeSeriesLifecycleActionsIT#testWaitForSnapshot test

This change adds some randomness and cleanup step to TimeSeriesLifecycleActionsIT#testWaitForSnapshot and testWaitForSnapshotSlmExecutedBefore tests in attempt to make them stable.

Reletes to #50781

* Formatting changes

* Longer timeout
probakowski added a commit that referenced this issue Jan 14, 2020
* ILM action to wait for SLM policy execution (#50454)

This change add new ILM action to wait for SLM policy execution to ensure that index has snapshot before deletion.

Closes #45067

* Fix flaky TimeSeriesLifecycleActionsIT#testWaitForSnapshot test

This change adds some randomness and cleanup step to TimeSeriesLifecycleActionsIT#testWaitForSnapshot and testWaitForSnapshotSlmExecutedBefore tests in attempt to make them stable.

Reletes to #50781

* Formatting changes

* Longer timeout

* Fix Map.of in Java8

* Unused import removed
@probakowski
Copy link
Contributor

Closing this one, looks like it's successfully fixed by #50818

@dakrone
Copy link
Member

dakrone commented Jan 15, 2020

The failed today on the master intake branch: https://gradle-enterprise.elastic.co/s/aalmk4jiei77w

The same error:

java.lang.AssertionError
: 

Expected: "completed"
     but: was "wait_for_snapshot"

@dakrone dakrone reopened this Jan 15, 2020
tvernum added a commit that referenced this issue Jan 20, 2020
This test was recently un-muted, but is still failing

Relates: #50781
tvernum added a commit to tvernum/elasticsearch that referenced this issue Jan 20, 2020
This test was recently un-muted, but is still failing

Relates: elastic#50781
Backport of: elastic#51203
tvernum added a commit that referenced this issue Jan 20, 2020
This test was recently un-muted, but is still failing

Relates: #50781
Backport of: #51203
tvernum added a commit to tvernum/elasticsearch that referenced this issue Jan 21, 2020
This test was recently un-muted, but is still failing

Relates: elastic#50781
Backport of: elastic#51203
tvernum added a commit that referenced this issue Jan 21, 2020
This test was recently un-muted, but is still failing

Relates: #50781
Backport of: #51203
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this issue Jan 23, 2020
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this issue Jan 23, 2020
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this issue Jan 23, 2020
… and testWaitForSnapshotSlmExecutedBefore test (elastic#50818)

* Fix flaky TimeSeriesLifecycleActionsIT#testWaitForSnapshot test

This change adds some randomness and cleanup step to TimeSeriesLifecycleActionsIT#testWaitForSnapshot and testWaitForSnapshotSlmExecutedBefore tests in attempt to make them stable.

Reletes to elastic#50781

* Formatting changes

* Longer timeout
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this issue Jan 23, 2020
This test was recently un-muted, but is still failing

Relates: elastic#50781
@droberts195
Copy link
Contributor

testWaitForSnapshotSlmExecutedBefore failed again on master with the same error as before in https://gradle-enterprise.elastic.co/s/zqejrnbnah5bu

I re-muted testWaitForSnapshotSlmExecutedBefore on master in c6c628b

@cbuescher
Copy link
Member

@dnhatn
Copy link
Member

dnhatn commented Feb 13, 2020

@probakowski
Copy link
Contributor

I'll close this issue, given that it hasn't failed for over 900 builds since #51892 has been merged:
https://ela.st/wait-for-snapshot
https://ela.st/wait-for-snapshot-before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >test-failure Triaged test failures from CI
Projects
None yet
Development

No branches or pull requests