Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_doc should work as an alias for the actual type on 6.7 #39469

Closed
jpountz opened this issue Feb 27, 2019 · 2 comments
Closed

_doc should work as an alias for the actual type on 6.7 #39469

jpountz opened this issue Feb 27, 2019 · 2 comments
Labels
blocker :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. v6.7.0

Comments

@jpountz
Copy link
Contributor

jpountz commented Feb 27, 2019

Mixed clusters raised an issue with the move to typeless APIs as some internal services such as machine learning need to keep interacting with their internal index during rolling upgrades.

As a consequence moving to typeless APIs in 7.x would break rolling upgrades since 6.7 nodes won't understand these calls. We agreed to treat _doc as an alias of the actual type of the index on 6.7 for the get, index, update, delete and bulk APIs to prevent this issue.

Relates #39018
@jpountz jpountz added blocker :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. v6.7.0 labels Feb 27, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@jakelandis jakelandis mentioned this issue Feb 27, 2019
Closed
4 tasks
@droberts195 droberts195 mentioned this issue Feb 28, 2019
Merged
jpountz added a commit to jpountz/elasticsearch that referenced this issue Feb 28, 2019
@jpountz
Make _doc work as an alias of the actual type of an index.
58eb61a 
This is similar to the work that has been done on 7.x to make typeless API calls
work on indices that have types, except that this commit doesn't introduce
typeless calls, eg. the REST API spec or REST handlers haven't been updated.

It only affects the get, index, update, delete and bulk APIs. Other APIs that
require types such as explain or termvectors are left unchanged.

This is necesarry to allow for rolling upgrades from 6.7 to 7.x while internal
indices might remain queried during upgrade by nodes that are on either version.

Closes elastic#39469
@jpountz jpountz mentioned this issue Feb 28, 2019
Merged
jpountz added a commit that referenced this issue Mar 1, 2019
@jpountz
Make _doc work as an alias of the actual type of an index. (#39505)
f14405a 
This is similar to the work that has been done on 7.x to make typeless API calls
work on indices that have types, except that this commit doesn't introduce
typeless calls, eg. the REST API spec or REST handlers haven't been updated.

It only affects the get, index, update, delete and bulk APIs. Other APIs that
require types such as explain or termvectors are left unchanged.

This is necesarry to allow for rolling upgrades from 6.7 to 7.x while internal
indices might remain queried during upgrade by nodes that are on either version.

Closes #39469
@jpountz
Copy link
Contributor Author

jpountz commented Mar 5, 2019

Closed via #39505.

@jpountz jpountz closed this as completed Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. v6.7.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpountz @elasticmachine