Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoteClusterConnectionTests.testCloseWhileConcurrentlyConnecting sporadically fails #24010

Closed
javanna opened this issue Apr 10, 2017 · 0 comments
Assignees
Labels
>test Issues or PRs that are addressing/adding tests >test-failure Triaged test failures from CI

Comments

@javanna
Copy link
Member

javanna commented Apr 10, 2017

From https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+multijob-unix-compatibility/os=oraclelinux/811:

> Throwable #1: com.carrotsearch.randomizedtesting.UncaughtExceptionError: Captured an uncaught exception in thread: Thread[id=2346, name=elasticsearch[org.elasticsearch.action.search.RemoteClusterConnectionTests][management][T#2], state=RUNNABLE, group=TGRP-RemoteClusterConnectionTests]
   > 	at __randomizedtesting.SeedInfo.seed([635D3E120146B328:651D6287125AC38E]:0)
   > Caused by: java.lang.AssertionError: shit's been called twice
   > 	at __randomizedtesting.SeedInfo.seed([635D3E120146B328]:0)
   > 	at org.elasticsearch.action.search.RemoteClusterConnectionTests$4.lambda$run$1(RemoteClusterConnectionTests.java:497)
   > 	at org.elasticsearch.action.ActionListener$1.onFailure(ActionListener.java:68)
   > 	at org.elasticsearch.action.ActionListener.onFailure(ActionListener.java:102)
   > 	at org.elasticsearch.action.search.RemoteClusterConnection$ConnectHandler$1.lambda$doRun$1(RemoteClusterConnection.java:339)
   > 	at org.elasticsearch.action.ActionListener$1.onFailure(ActionListener.java:68)
   > 	at org.elasticsearch.action.search.RemoteClusterConnection$ConnectHandler$SniffClusterStateResponseHandler.handleResponse(RemoteClusterConnection.java:485)
   > 	at org.elasticsearch.action.search.RemoteClusterConnection$ConnectHandler$SniffClusterStateResponseHandler.handleResponse(RemoteClusterConnection.java:432)
   > 	at org.elasticsearch.transport.TransportService$ContextRestoreResponseHandler.handleResponse(TransportService.java:1030)
   > 	at org.elasticsearch.transport.TransportService$ContextRestoreResponseHandler.handleResponse(TransportService.java:1030)
   > 	at org.elasticsearch.transport.TcpTransport$2.doRun(TcpTransport.java:1379)
   > 	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.doRun(ThreadContext.java:638)
   > 	at org.elasticsearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:37)
   > 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
   > 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
   > 	at java.lang.Thread.run(Thread.java:745)
   > Caused by: java.lang.RuntimeException
   > 	at org.elasticsearch.action.search.RemoteClusterConnectionTests$4.lambda$run$1(RemoteClusterConnectionTests.java:494)
   > 	at org.elasticsearch.action.ActionListener$1.onFailure(ActionListener.java:68)
   > 	at org.elasticsearch.action.ActionListener.onFailure(ActionListener.java:102)
   > 	at org.elasticsearch.action.search.RemoteClusterConnection$ConnectHandler$1.lambda$doRun$1(RemoteClusterConnection.java:339)
   > 	at org.elasticsearch.action.ActionListener$1.onFailure(ActionListener.java:68)
   > 	at org.elasticsearch.action.search.RemoteClusterConnection$ConnectHandler.collectRemoteNodes(RemoteClusterConnection.java:400)
   > 	at org.elasticsearch.action.search.RemoteClusterConnection$ConnectHandler$1.doRun(RemoteClusterConnection.java:344)
   > 	at org.elasticsearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:37)
   > 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
   > 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
   > 	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:569)
   > 	... 3 more

I couldn't reproduce this failure.

@javanna javanna added >test-failure Triaged test failures from CI >test Issues or PRs that are addressing/adding tests labels Apr 10, 2017
@s1monw s1monw closed this as completed in f9cfe86 May 16, 2017
s1monw added a commit that referenced this issue May 16, 2017
…ads aborts

Today we assert hart if failure listeners are invoked more than once. Yet, this
can happen if we cancel the execution since the caller and the handler will get
the exception on the cancelable threads and will notify the listener concurrently
if timinig allows. This commit relaxes the assertion towards handling multiple
invocations with `ExecutionCancelledException`

Closes #24010
Closes #24179
Closes vagnerclementino/elasticsearch/#98
s1monw added a commit that referenced this issue May 16, 2017
…ads aborts

Today we assert hart if failure listeners are invoked more than once. Yet, this
can happen if we cancel the execution since the caller and the handler will get
the exception on the cancelable threads and will notify the listener concurrently
if timinig allows. This commit relaxes the assertion towards handling multiple
invocations with `ExecutionCancelledException`

Closes #24010
Closes #24179
Closes vagnerclementino/elasticsearch/#98
s1monw added a commit that referenced this issue May 16, 2017
…ads aborts

Today we assert hart if failure listeners are invoked more than once. Yet, this
can happen if we cancel the execution since the caller and the handler will get
the exception on the cancelable threads and will notify the listener concurrently
if timinig allows. This commit relaxes the assertion towards handling multiple
invocations with `ExecutionCancelledException`

Closes #24010
Closes #24179
Closes vagnerclementino/elasticsearch/#98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>test Issues or PRs that are addressing/adding tests >test-failure Triaged test failures from CI
Projects
None yet
Development

No branches or pull requests

2 participants