Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logger usage check for Log4j 2 #20243

Closed
jasontedor opened this issue Aug 31, 2016 · 0 comments · Fixed by #20490
Closed

Update logger usage check for Log4j 2 #20243

jasontedor opened this issue Aug 31, 2016 · 0 comments · Fixed by #20490
Assignees
@ywelsch
Labels
:Core/Infra/Logging Log management and logging utilities :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team

Comments

@jasontedor
Copy link
Member

The logger usage check was designed for the ESLogger API, which was a simplified wrapper around the Log4j API. This check is useful, but the ESLogger wrapper will be removed after #20235 instead exposing the Log4j 2 API directly. The Log4j 2 API is significantly more complicated and the logger usage check will need to be updated for this API.
@jasontedor jasontedor added :Delivery/Build Build or test infrastructure :Core/Infra/Logging Log management and logging utilities labels Aug 31, 2016
@jasontedor jasontedor mentioned this issue Aug 31, 2016
Merged
@ywelsch ywelsch mentioned this issue Sep 14, 2016
Merged
ywelsch added a commit to ywelsch/elasticsearch that referenced this issue Sep 21, 2016
@ywelsch
Fix logger usage checker for Log4j 2
191fada 
With the switch to Log4j 2 throughout our code base, the logger usage checker was temporarily disabled. This commit
adapts the checks to work with Log4j 2 and re-enables the Gradle checks.

Closes elastic#20243
ywelsch added a commit that referenced this issue Sep 21, 2016
@ywelsch
Fix logger usage checker for Log4j 2
fb0648a 
With the switch to Log4j 2 throughout our code base, the logger usage checker was temporarily disabled. This commit
adapts the checks to work with Log4j 2 and re-enables the Gradle checks.

Closes #20243
ywelsch added a commit that referenced this issue Sep 21, 2016
@ywelsch
Fix logger usage checker for Log4j 2
a078862 
With the switch to Log4j 2 throughout our code base, the logger usage checker was temporarily disabled. This commit
adapts the checks to work with Log4j 2 and re-enables the Gradle checks.

Closes #20243
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ywelsch ywelsch

Labels
:Core/Infra/Logging Log management and logging utilities :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix logger usage check for Log4j 2 ywelsch/elasticsearch
3 participants
@ywelsch @mark-vieira @jasontedor