Skip to content

Commit

Permalink
Add BucketMetricValue interface (#24188)
Browse files Browse the repository at this point in the history
Unlike other implementations of InternalNumericMetricsAggregation.SingleValue,
the InternalBucketMetricValue aggregation currently doesn't implement a
specialized interface that exposes the `keys()` method. This change adds this so
that clients can access the keys via the interface.
  • Loading branch information
cbuescher committed Apr 19, 2017
1 parent 8562092 commit 7c44eff
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
/*
* Licensed to Elasticsearch under one or more contributor
* license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright
* ownership. Elasticsearch licenses this file to you under
* the Apache License, Version 2.0 (the "License"); you may
* not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

package org.elasticsearch.search.aggregations.pipeline.bucketmetrics;

import org.elasticsearch.search.aggregations.metrics.NumericMetricsAggregation;

public interface BucketMetricValue extends NumericMetricsAggregation.SingleValue {

String[] keys();
}
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
import java.util.List;
import java.util.Map;

public class InternalBucketMetricValue extends InternalNumericMetricsAggregation.SingleValue {
public class InternalBucketMetricValue extends InternalNumericMetricsAggregation.SingleValue implements BucketMetricValue {
public static final String NAME = "bucket_metric_value";

private double value;
Expand Down Expand Up @@ -72,6 +72,7 @@ public double value() {
return value;
}

@Override
public String[] keys() {
return keys;
}
Expand Down

0 comments on commit 7c44eff

Please sign in to comment.