-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update spec for ESQL async query stop #3643
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me!
Pausing before merging to verify with @pquentin about what the missing tests indicates. I'm pretty sure it's fine, but I want to make sure. |
It will probably be non-trivial to test async requests within the context of the spec, since they require some special timing, so I am not surprised the spec does not test them. That said, please tell me if anything needs to be added here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please make the body binary as done in #3639? The current representation isn't usable for typed client. (The current behavior of "return structured response, unless it's ready, then you get binary data" is unfortunate.)
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
b9d056b
to
c96c057
Compare
c96c057
to
90d2c92
Compare
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
@pquentin updated, please review |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3643-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 585f69729291cfda4acb5c47a7466abe6c42e9c0
# Push it to GitHub
git push --set-upstream origin backport-3643-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x Then, create a pull request where the |
* Update spec for ESQL async query stop (cherry picked from commit 585f697)
Update spec for:
POST query/stop
API