Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Clarify Count API query options #3611

Merged
merged 1 commit into from
Jan 27, 2025
Merged

[DOCS] Clarify Count API query options #3611

merged 1 commit into from
Jan 27, 2025

Conversation

marciw
Copy link
Contributor

@marciw marciw commented Jan 24, 2025

Applies changes from elastic/elasticsearch#120564: notes that you can use the q parameter or a query in the request body, but not both. Plus other incidental sprucing.

Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
count 🟢 34/34 34/34

You can validate this API yourself by using the make validate target.

@marciw marciw marked this pull request as ready for review January 24, 2025 21:17
@marciw marciw requested a review from lcawl January 24, 2025 21:21
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@marciw marciw merged commit 8e9c71a into main Jan 27, 2025
16 checks passed
@marciw marciw deleted the mw-count-options branch January 27, 2025 16:49
github-actions bot pushed a commit that referenced this pull request Jan 27, 2025
(cherry picked from commit 8e9c71a)
github-actions bot pushed a commit that referenced this pull request Jan 27, 2025
(cherry picked from commit 8e9c71a)
marciw added a commit that referenced this pull request Jan 27, 2025
(cherry picked from commit 8e9c71a)

Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
marciw added a commit that referenced this pull request Jan 27, 2025
(cherry picked from commit 8e9c71a)

Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants