Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bulk, count, clear scroll, close PIT examples #3510

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

@lcawl lcawl requested a review from a team January 14, 2025 08:23
@lcawl lcawl mentioned this pull request Jan 14, 2025
63 tasks
@lcawl lcawl marked this pull request as ready for review January 14, 2025 08:26
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
bulk 🟢 445/445 463/463
clear_scroll 🟢 17/17 17/17
close_point_in_time 🟢 7/7 7/7
count 🟢 34/34 34/34

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
bulk 🟢 445/445 463/463
clear_scroll 🟢 17/17 17/17
close_point_in_time 🟢 7/7 7/7
count 🟢 34/34 34/34

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl merged commit 4eeb458 into main Jan 15, 2025
8 checks passed
@lcawl lcawl deleted the global-examples1 branch January 15, 2025 17:37
github-actions bot pushed a commit that referenced this pull request Jan 15, 2025
Copy link
Contributor

The backport to 8.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-3510-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4eeb458b9a88fc34d904279c9fdeb4c65a370a66
# Push it to GitHub
git push --set-upstream origin backport-3510-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17

Then, create a pull request where the base branch is 8.17 and the compare/head branch is backport-3510-to-8.17.

lcawl added a commit that referenced this pull request Jan 15, 2025
(cherry picked from commit 4eeb458)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
lcawl added a commit that referenced this pull request Jan 15, 2025
@lcawl
Copy link
Contributor Author

lcawl commented Jan 15, 2025

💚 All backports created successfully

Status Branch Result
8.17

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants