Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add synonym API examples #3486

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Add synonym API examples #3486

merged 2 commits into from
Jan 9, 2025

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 8, 2025 •
edited
Loading

Relates to #2482

This PR copies the examples from https://www.elastic.co/guide/en/elasticsearch/reference/master/synonyms-apis.html
It also adds the missing doc_id values and edits some descriptions.

@lcawl lcawl mentioned this pull request Jan 8, 2025
Open
63 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
synonyms.delete_synonym_rule 🟢 7/7 7/7
synonyms.delete_synonym 🟢 6/6 6/6
synonyms.get_synonym_rule 🟢 4/4 4/4
synonyms.get_synonym 🟢 16/16 16/16
synonyms.get_synonyms_sets 🟢 6/6 6/6
synonyms.put_synonym_rule 🟢 4/4 4/4
synonyms.put_synonym 🟢 26/26 26/26

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl marked this pull request as ready for review January 9, 2025 05:22
@lcawl lcawl requested a review from a team as a code owner January 9, 2025 05:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
synonyms.delete_synonym_rule 🟢 7/7 7/7
synonyms.delete_synonym 🟢 6/6 6/6
synonyms.get_synonym_rule 🟢 4/4 4/4
synonyms.get_synonym 🟢 16/16 16/16
synonyms.get_synonyms_sets 🟢 6/6 6/6
synonyms.put_synonym_rule 🟢 4/4 4/4
synonyms.put_synonym 🟢 26/26 26/26

You can validate these APIs yourself by using the make validate target.

JoshMock
JoshMock approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lcawl lcawl merged commit 83092c8 into main Jan 9, 2025
10 checks passed
@lcawl lcawl deleted the synonoym-examples branch January 9, 2025 17:57
github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
@lcawl @github-actions
Add synonym API examples (#3486)
8e1f4ef 
(cherry picked from commit 83092c8)
@github-actions github-actions bot mentioned this pull request Jan 9, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
@lcawl @github-actions
Add synonym API examples (#3486)
329afc8 
(cherry picked from commit 83092c8)
@github-actions github-actions bot mentioned this pull request Jan 9, 2025
Merged
lcawl added a commit that referenced this pull request Jan 9, 2025
@github-actions @lcawl
Add synonym API examples (#3486) (#3497)
3166b78 
(cherry picked from commit 83092c8)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
lcawl added a commit that referenced this pull request Jan 9, 2025
@github-actions @lcawl
Add synonym API examples (#3486) (#3498)
ad6fd3d 
(cherry picked from commit 83092c8)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshMock JoshMock JoshMock approved these changes

Assignees
No one assigned
Labels
backport 8.x backport 8.17 compiler documentation specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcawl @JoshMock