Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SLM API examples #3470

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Add SLM API examples #3470

merged 5 commits into from
Jan 9, 2025

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 8, 2025 •
edited
Loading

Relates to #2482

This PR copies examples from https://www.elastic.co/guide/en/elasticsearch/reference/master/snapshot-lifecycle-management-api.html
It also adds missing doc_id values and adds some minor changes in the descriptions.

@lcawl lcawl mentioned this pull request Jan 8, 2025
Closed
65 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
slm.put_lifecycle 🟢 4/4 4/4

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl requested a review from a team January 8, 2025 18:19
@lcawl lcawl marked this pull request as ready for review January 8, 2025 18:20
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
slm.delete_lifecycle 🟢 4/4 4/4
slm.execute_lifecycle 🟢 4/4 4/4
slm.execute_retention 🟢 4/4 4/4
slm.get_lifecycle 🟢 16/16 16/16
slm.get_stats 🟢 4/4 4/4
slm.get_status 🟢 4/4 4/4
slm.put_lifecycle 🟢 4/4 4/4
slm.start ⚪ Missing test Missing test
slm.stop 🟢 4/4 4/4

You can validate these APIs yourself by using the make validate target.

marciw
marciw approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@marciw marciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👽

specification/slm/put_lifecycle/examples/request/PutSnapshotLifecycleRequestExample2.yaml Outdated Show resolved Hide resolved
lcawl and others added 2 commits January 9, 2025 11:55
@lcawl @marciw
Update specification/slm/put_lifecycle/examples/request/PutSnapshotLi…
09580d3 
…fecycleRequestExample2.yaml

Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
@lcawl
Merge branch 'main' into slm-examples
e9bac74
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
slm.delete_lifecycle 🟢 4/4 4/4
slm.execute_lifecycle 🟢 4/4 4/4
slm.execute_retention 🟢 4/4 4/4
slm.get_lifecycle 🟢 16/16 16/16
slm.get_stats 🟢 4/4 4/4
slm.get_status 🟢 4/4 4/4
slm.put_lifecycle 🟢 4/4 4/4
slm.start ⚪ Missing test Missing test
slm.stop 🟢 4/4 4/4

You can validate these APIs yourself by using the make validate target.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
slm.delete_lifecycle 🟢 4/4 4/4
slm.execute_lifecycle 🟢 4/4 4/4
slm.execute_retention 🟢 4/4 4/4
slm.get_lifecycle 🟢 16/16 16/16
slm.get_stats 🟢 4/4 4/4
slm.get_status 🟢 4/4 4/4
slm.put_lifecycle 🟢 4/4 4/4
slm.start ⚪ Missing test Missing test
slm.stop 🟢 4/4 4/4

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl merged commit 41ea741 into main Jan 9, 2025
8 checks passed
@lcawl lcawl deleted the slm-examples branch January 9, 2025 20:03
github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
@lcawl @github-actions
Add SLM API examples (#3470)
c426bc2 
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>

---------

Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
(cherry picked from commit 41ea741)
@github-actions github-actions bot mentioned this pull request Jan 9, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
@lcawl @github-actions
Add SLM API examples (#3470)
02b86f3 
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>

---------

Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
(cherry picked from commit 41ea741)
@github-actions github-actions bot mentioned this pull request Jan 9, 2025
Merged
lcawl added a commit that referenced this pull request Jan 9, 2025
@github-actions @lcawl
Add SLM API examples (#3470) (#3501)
748fb19 
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>

---------

Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
(cherry picked from commit 41ea741)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
lcawl added a commit that referenced this pull request Jan 9, 2025
@github-actions @lcawl
Add SLM API examples (#3470) (#3502)
13b8445 
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>

---------

Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
(cherry picked from commit 41ea741)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marciw marciw marciw approved these changes

Assignees
No one assigned
Labels
backport 8.x backport 8.17 documentation specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcawl @marciw