-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add endpoint URLs to the API specification (phase 1) #3469
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
070c15f
to
0adbff0
Compare
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
0adbff0
to
d7b16a0
Compare
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
The JS compiler part looks good 🙂 |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3469-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c23216f42349809f49383f84074df8bceb2e8bdf
# Push it to GitHub
git push --set-upstream origin backport-3469-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x Then, create a pull request where the |
The endpoints' URL path templates and http methods are currently missing from the API spec (TypeScript source) and are imported from the json rest-spec when the spec if compiled to
schema.json
. This means that the API spec currently does not contain all the information defining the API.This PR allows endpoint URLs to be captured in request definitions in the API spec. The format follows that of the json rest-spec and schema.json:
This PR also includes a code modification utility to automatically add this information to the API spec from json rest-spec. Only two endpoints have been updated to test and demonstrate this utility. The full update will be done in a subsequent PR so that this one can be backported to other branches.
This PR is split in several commits:
urls
field, along with validation.urls
property.urls
.