Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snapshot.repository_analyze #3403

Merged
merged 8 commits into from
Jan 15, 2025
Merged

Add snapshot.repository_analyze #3403

merged 8 commits into from
Jan 15, 2025
+2,341 −5

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 1, 2025

Relates to #3377

This PR adds a missing specification based on https://www.elastic.co/guide/en/elasticsearch/reference/master/repo-analysis-api.html

@lcawl lcawl requested a review from a team January 1, 2025 08:10
@lcawl lcawl mentioned this pull request Jan 1, 2025
Closed
26 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 1, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
snapshot.repository_analyze ⚪ Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl marked this pull request as ready for review January 2, 2025 16:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
snapshot.repository_analyze ⚪ Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
snapshot.repository_analyze ⚪ Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin self-assigned this Jan 7, 2025
flobernd
flobernd reviewed Jan 8, 2025
View reviewed changes
specification/snapshot/repository_analyze/SnapshotAnalyzeRepositoryResponse.ts Outdated
/**
* The limit on the size of a blob written during the test.
*/
max_blob_size: string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this field and the following ones be modeled as ByteSize?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated these properties to use "Duration" and "ByteSize" data types in b151058

specification/snapshot/repository_analyze/SnapshotAnalyzeRepositoryResponse.ts Outdated Show resolved Hide resolved
specification/snapshot/repository_analyze/SnapshotAnalyzeRepositoryResponse.ts Outdated Show resolved Hide resolved
specification/snapshot/repository_analyze/SnapshotAnalyzeRepositoryResponse.ts Outdated Show resolved Hide resolved
specification/snapshot/repository_analyze/SnapshotAnalyzeRepositoryResponse.ts Outdated Show resolved Hide resolved
specification/snapshot/repository_analyze/SnapshotAnalyzeRepositoryResponse.ts Show resolved Hide resolved
specification/snapshot/repository_analyze/SnapshotAnalyzeRepositoryResponse.ts Outdated Show resolved Hide resolved
specification/snapshot/repository_analyze/SnapshotAnalyzeRepositoryResponse.ts Show resolved Hide resolved
specification/snapshot/repository_analyze/SnapshotAnalyzeRepositoryResponse.ts Outdated Show resolved Hide resolved
lcawl and others added 5 commits January 8, 2025 13:52
@lcawl @flobernd
Update specification/snapshot/repository_analyze/SnapshotAnalyzeRepos…
41c9935 
…itoryResponse.ts

Co-authored-by: Florian Bernd <git@flobernd.de>
@lcawl @flobernd
Update specification/snapshot/repository_analyze/SnapshotAnalyzeRepos…
f81a08e 
…itoryResponse.ts

Co-authored-by: Florian Bernd <git@flobernd.de>
@lcawl @flobernd
Update specification/snapshot/repository_analyze/SnapshotAnalyzeRepos…
b8dce5e 
…itoryResponse.ts

Co-authored-by: Florian Bernd <git@flobernd.de>
@lcawl @flobernd
Update specification/snapshot/repository_analyze/SnapshotAnalyzeRepos…
b2bb92b 
…itoryResponse.ts

Co-authored-by: Florian Bernd <git@flobernd.de>
@lcawl
Update data types
b151058
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
snapshot.repository_analyze ⚪ Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@lcawl
Copy link
Contributor Author

lcawl commented Jan 9, 2025

I think I've addressed all the feedback, thanks!

@pquentin pquentin removed their assignment Jan 13, 2025
flobernd
flobernd approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you 🙂

@lcawl lcawl merged commit fa1f90c into main Jan 15, 2025
8 checks passed
@lcawl lcawl deleted the respository-analysis branch January 15, 2025 15:33
github-actions bot pushed a commit that referenced this pull request Jan 15, 2025
@lcawl @github-actions
Add snapshot.repository_analyze (#3403)
f115c4f 
Co-authored-by: Florian Bernd <git@flobernd.de>
(cherry picked from commit fa1f90c)
@github-actions github-actions bot mentioned this pull request Jan 15, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jan 15, 2025
@lcawl @github-actions
Add snapshot.repository_analyze (#3403)
ed24404 
Co-authored-by: Florian Bernd <git@flobernd.de>
(cherry picked from commit fa1f90c)
@github-actions github-actions bot mentioned this pull request Jan 15, 2025
Merged
lcawl added a commit that referenced this pull request Jan 15, 2025
@github-actions @lcawl
Add snapshot.repository_analyze (#3403) (#3530)
807bbd7 
Co-authored-by: Florian Bernd <git@flobernd.de>
(cherry picked from commit fa1f90c)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
lcawl added a commit that referenced this pull request Jan 15, 2025
@github-actions @lcawl
Add snapshot.repository_analyze (#3403) (#3531)
b628c5a 
Co-authored-by: Florian Bernd <git@flobernd.de>
(cherry picked from commit fa1f90c)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flobernd flobernd flobernd approved these changes

Assignees
No one assigned
Labels
backport 8.x backport 8.17 specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lcawl @flobernd @pquentin