-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simulate.ingest specification #3400
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
74fac23
to
47397a4
Compare
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
I have 2 main doubts I need to clear with this one:
|
specification/simulate/ingest/SimulateIngestRequestExample3.yaml
Outdated
Show resolved
Hide resolved
specification/simulate/ingest/SimulateIngestResponseExample3.yaml
Outdated
Show resolved
Hide resolved
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
1 similar comment
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my concerns are all addressed now. looks like you have a couple conflicts to work out, but otherwise LGTM.
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3400-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 46b99ee0c07b9aabd0fa6f3dcdcc63738cb219d9
# Push it to GitHub
git push --set-upstream origin backport-3400-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-3400-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 46b99ee0c07b9aabd0fa6f3dcdcc63738cb219d9
# Push it to GitHub
git push --set-upstream origin backport-3400-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17 Then, create a pull request where the |
(cherry picked from commit 46b99ee)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit 46b99ee)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit 46b99ee)
Relates to #3377
This PR adds a missing specification based on https://www.elastic.co/guide/en/elasticsearch/reference/master/simulate-ingest-api.html
It also moves the existing simulate ingest example files to appropriate subfolders