Add inference.stream_inference and inference.update #3399
Conversation
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
| */ | ||
|
|
||
| export class Response { | ||
| body: {} |
There was a problem hiding this comment.
we need to discuss how to handle the response, because the server sends text while we always expect json
There was a problem hiding this comment.
I think the same is true of the cat APIs, since I started playing with in #3419
There was a problem hiding this comment.
the cat APIs all have options to turn the output into json (query parameter ?format=json), while this one cannot be converted
specification/inference/stream_inference/StreamInferenceRequest.ts
Outdated
Show resolved
Hide resolved
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
1 similar comment
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
waiting to merge #3313 so that we can use the new StreamResult type (alias for ArrayBuffer that we'll use for streaming responses) |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
71ec0ff to
6ae5198
Compare
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
95551fa to
d7fd20e
Compare
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
1 similar comment
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
d7fd20e to
38a1c76
Compare
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
38a1c76 to
a910fa9
Compare
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
@lcawl added the new type, ready to be merged! could you just check the doc overlay? I may have messed something up while rebasing ^^" |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
The output LGTM, thanks! |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3399-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cf1f2c9aef10b395681418361ca455610bcf8531
# Push it to GitHub
git push --set-upstream origin backport-3399-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.xThen, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-3399-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cf1f2c9aef10b395681418361ca455610bcf8531
# Push it to GitHub
git push --set-upstream origin backport-3399-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17Then, create a pull request where the |
* Add inference.stream_inference * Add inference.update * Add array of strings to stream inference input * update inference response with streamresult type * fix overlay * fix wrong rebase * fix overlay wrong indent --------- Co-authored-by: Laura Trotta <laura.trotta@elastic.co>
* Add inference.stream_inference * Add inference.update * Add array of strings to stream inference input * update inference response with streamresult type * fix overlay * fix wrong rebase * fix overlay wrong indent --------- Co-authored-by: Laura Trotta <laura.trotta@elastic.co>
Relates to #3377, elastic/elasticsearch#119472
This PR adds a missing specification based on https://www.elastic.co/guide/en/elasticsearch/reference/master/stream-inference-api.html and https://www.elastic.co/guide/en/elasticsearch/reference/master/update-inference-api.html