-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add security.update_settings and security.get_settings #3396
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
specification/security/get_settings/SecurityGetSettingsResponse.ts
Outdated
Show resolved
Hide resolved
specification/security/update_settings/SecurityUpdateSettingsRequest.ts
Outdated
Show resolved
Hide resolved
specification/security/update_settings/SecurityUpdateSettingsRequest.ts
Outdated
Show resolved
Hide resolved
specification/security/update_settings/SecurityUpdateSettingsRequest.ts
Outdated
Show resolved
Hide resolved
after these fixes we'll still have a validation error, not because of this specific API, but it's just because it uses IndexSettings, which is still not mapped 100% correctly |
…e.ts Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
…equest.ts Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
…equest.ts Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
…equest.ts Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
That seems okay to me. I think this PR work is now complete but if there's something still outstanding just lmk! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com> (cherry picked from commit c016f9f)
Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com> (cherry picked from commit c016f9f)
Relates to #3377
This PR adds two missing specifications based on information in https://www.elastic.co/guide/en/elasticsearch/reference/master/security-api-update-settings.html and https://www.elastic.co/guide/en/elasticsearch/reference/master/security-api-get-settings.html