Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security.update_settings and security.get_settings #3396

Merged
merged 7 commits into from
Jan 11, 2025
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 31, 2024

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.get_settings 🔴 3/3 2/3
security.update_settings 🔴 0/2 2/2

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl marked this pull request as ready for review December 31, 2024 23:10
@lcawl lcawl requested a review from a team December 31, 2024 23:54
@l-trotta l-trotta self-assigned this Jan 8, 2025
@l-trotta
Copy link
Contributor

l-trotta commented Jan 8, 2025

after these fixes we'll still have a validation error, not because of this specific API, but it's just because it uses IndexSettings, which is still not mapped 100% correctly

lcawl and others added 7 commits January 10, 2025 07:31
…e.ts

Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
…equest.ts

Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
…equest.ts

Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
…equest.ts

Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.activate_user_profile 🟢 9/9 9/9
security.authenticate 🟢 30/30 30/30
security.bulk_delete_role 🟢 1/1 1/1
security.bulk_put_role 🟢 1/1 1/1
security.bulk_update_api_keys 🟢 4/4 4/4
security.change_password 🟢 9/9 9/9
security.clear_api_key_cache 🟢 13/13 13/13
security.clear_cached_privileges 🟢 3/3 3/3
security.clear_cached_realms 🟢 1/1 1/1
security.clear_cached_roles 🟢 2/2 2/2
security.clear_cached_service_tokens 🟢 4/4 4/4
security.create_api_key 🟢 68/68 59/59
security.create_cross_cluster_api_key 🟢 3/3 3/3
security.create_service_token 🟢 3/3 3/3
security.delegate_pki Missing test Missing test
security.delete_privileges 🟢 6/6 6/6
security.delete_role_mapping 🟢 9/9 9/9
security.delete_role 🟢 8/8 8/8
security.delete_service_token Missing test Missing test
security.delete_user 🟢 9/9 9/9
security.disable_user_profile 🟢 1/1 1/1
security.disable_user 🟢 3/3 3/3
security.enable_user_profile 🟢 1/1 1/1
security.enable_user 🟢 4/4 4/4
security.enroll_kibana Missing test Missing test
security.enroll_node Missing test Missing test
security.get_api_key 🟢 26/26 26/26
security.get_builtin_privileges 🟢 1/1 1/1
security.get_privileges 🟢 12/12 12/12
security.get_role_mapping 🔴 18/18 10/18
security.get_role 🔴 24/24 22/24
security.get_service_accounts Missing test Missing test
security.get_service_credentials 🟢 1/1 1/1
security.get_settings 🟢 3/3 3/3
security.get_token 🟢 25/25 24/24
security.get_user_privileges 🔴 8/8 7/8
security.get_user_profile 🟢 8/8 8/8
security.get_user 🟢 25/25 25/25
security.grant_api_key 🟢 7/7 7/7
security.has_privileges_user_profile 🟢 3/3 3/3
security.has_privileges 🟢 24/24 24/24
security.invalidate_api_key 🟢 12/12 12/12
security.invalidate_token 🟢 11/11 11/11
security.oidc_authenticate Missing test Missing test
security.oidc_logout Missing test Missing test
security.oidc_prepare_authentication Missing test Missing test
security.put_privileges 🟢 10/10 10/10
security.put_role_mapping 🔴 2/11 11/11
security.put_role 🟢 39/39 38/38
security.put_user 🟢 48/48 47/47
security.query_api_keys 🟢 14/14 14/14
security.query_role 🟢 2/2 2/2
security.query_user 🟢 4/4 4/4
security.saml_authenticate Missing test Missing test
security.saml_complete_logout Missing test Missing test
security.saml_invalidate Missing test Missing test
security.saml_logout Missing test Missing test
security.saml_prepare_authentication Missing test Missing test
security.saml_service_provider_metadata Missing test Missing test
security.suggest_user_profiles 🟢 1/1 1/1
security.update_api_key 🟢 5/5 5/5
security.update_cross_cluster_api_key 🟢 2/2 2/2
security.update_settings 🔴 1/2 2/2
security.update_user_profile_data 🟢 1/1 1/1

You can validate these APIs yourself by using the make validate target.

@lcawl
Copy link
Contributor Author

lcawl commented Jan 10, 2025

after these fixes we'll still have a validation error, not because of this specific API, but it's just because it uses IndexSettings, which is still not mapped 100% correctly

That seems okay to me. I think this PR work is now complete but if there's something still outstanding just lmk!

Copy link
Contributor

@l-trotta l-trotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lcawl lcawl merged commit c016f9f into main Jan 11, 2025
8 checks passed
@lcawl lcawl deleted the settings-specs branch January 11, 2025 03:45
github-actions bot pushed a commit that referenced this pull request Jan 11, 2025
Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
(cherry picked from commit c016f9f)
github-actions bot pushed a commit that referenced this pull request Jan 11, 2025
Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
(cherry picked from commit c016f9f)
l-trotta pushed a commit that referenced this pull request Jan 13, 2025
Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
(cherry picked from commit c016f9f)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
l-trotta pushed a commit that referenced this pull request Jan 13, 2025
Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
(cherry picked from commit c016f9f)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants