Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _resolve/cluster API #2427

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Add _resolve/cluster API #2427

merged 3 commits into from
Feb 21, 2024

Conversation

quux00
Copy link
Contributor

@quux00 quux00 commented Feb 20, 2024

A new endpoint _resolve/cluster was added to Elasticsearch 8.13.0.
End user docs can be found here: https://www.elastic.co/guide/en/elasticsearch/reference/master/indices-resolve-cluster-api.html

This endpoint is not supported in serverless, so the spec only marks it as available in "stack".

@quux00
Copy link
Contributor Author

quux00 commented Feb 20, 2024

I don't understand the validation failure error message here.

I am unable to run make validate locally. First, I'm not sure what command to run. When I try

make validate api=index type=request stack-version=8.13.0-SNAPSHOT

It says "Pulling latest flight recorder changes" and spins, never doing anything. I clone the flight recorder repo moments ago.

@pquentin
Copy link
Member

@quux00 I relaunched the failed build and it passed this time! This was a transient error where https://artifacts-api.elastic.co/v1/versions apparently returned XML or HTML instead of JSON.

It says "Pulling latest flight recorder changes" and spins, never doing anything. I clone the flight recorder repo moments ago.

Is your clone of clients-flights-recorder at the same level as elasticsearch-specification, and is git pull working there? It's the only thing it's supposed to do.

Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question around the response type, other than that it looks good!

Added documentation for fields in body response.wq
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.resolve_cluster Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@quux00
Copy link
Contributor Author

quux00 commented Feb 21, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.resolve_cluster ⚪ Missing test Missing test
You can validate these APIs yourself by using the make validate target.

Is there something else I need to do here (like add this new api to some metadata or config file)?

I tried running this locally but it fails:

└─ $ ▶ make validate api=indices.resolve_cluster type=request stack-version=8.13.0-SNAPSHOT
✖
    at run (/home/mpeterson/elasticsearch-specification/compiler/run-validations.js:175:12)
    exit code: 1
make: *** [Makefile:4: validate] Error 1

@Anaethelion
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.
API Status Request Response
indices.resolve_cluster ⚪ Missing test Missing test
You can validate these APIs yourself by using the make validate target.

Is there something else I need to do here (like add this new api to some metadata or config file)?

Just noticed the flight recorder that produces the json for validation didn't have an 8.13 branch run yet. I've triggered that and will relaunch the validation once its run has completed.

@Anaethelion Anaethelion self-requested a review February 21, 2024 18:59
Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quux00 quux00 merged commit 9c437e5 into main Feb 21, 2024
8 checks passed
@quux00 quux00 deleted the new-spec/resolve-cluster branch February 21, 2024 19:28
github-actions bot pushed a commit that referenced this pull request Feb 21, 2024
(cherry picked from commit 9c437e5)
Anaethelion pushed a commit that referenced this pull request Feb 22, 2024
(cherry picked from commit 9c437e5)

Co-authored-by: Michael Peterson <michael.peterson@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants