-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add _resolve/cluster API #2427
Add _resolve/cluster API #2427
Conversation
I don't understand the validation failure error message here. I am unable to run
It says "Pulling latest flight recorder changes" and spins, never doing anything. I clone the flight recorder repo moments ago. |
@quux00 I relaunched the failed build and it passed this time! This was a transient error where https://artifacts-api.elastic.co/v1/versions apparently returned XML or HTML instead of JSON.
Is your clone of clients-flights-recorder at the same level as elasticsearch-specification, and is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a question around the response type, other than that it looks good!
specification/indices/resolve_cluster/ResolveClusterResponse.ts
Outdated
Show resolved
Hide resolved
Added documentation for fields in body response.wq
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Is there something else I need to do here (like add this new api to some metadata or config file)? I tried running this locally but it fails:
|
Just noticed the flight recorder that produces the json for validation didn't have an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit 9c437e5)
A new endpoint
_resolve/cluster
was added to Elasticsearch 8.13.0.End user docs can be found here: https://www.elastic.co/guide/en/elasticsearch/reference/master/indices-resolve-cluster-api.html
This endpoint is not supported in serverless, so the spec only marks it as available in "stack".