Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSON spec] sync spec files #2343

Merged
merged 2 commits into from
Nov 9, 2023
Merged

[JSON spec] sync spec files #2343

merged 2 commits into from
Nov 9, 2023

Conversation

Anaethelion
Copy link
Contributor

This PR syncs the JSON spec files with the v8.11.0 Elasticsearch tag.

@Anaethelion Anaethelion requested a review from a team as a code owner November 8, 2023 10:39
JoshMock
JoshMock approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do you just copy these over from the ES repo's rest-api-spec directory and run the compiler? Just curious if we can automate it.

@Anaethelion
Copy link
Contributor Author

Yep its a direct copy of the spec files from the Elasticsearch repo with the exception of _common.json which shouldn't be copied, make contrib takes care of reformatting the JSON files and regen the API.

@Anaethelion Anaethelion merged commit 4cb8d4d into main Nov 9, 2023
5 checks passed
@Anaethelion Anaethelion deleted the lsf/sync_spec_files branch November 9, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshMock JoshMock JoshMock approved these changes

Assignees
No one assigned
Labels
specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anaethelion @JoshMock