Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing scores parameter in MLPutTrainedModelVocabularyRequest #2320

Closed
wants to merge 4 commits into from
Closed

Add missing scores parameter in MLPutTrainedModelVocabularyRequest #2320

wants to merge 4 commits into from

Conversation

dolaru
Copy link
Member

@dolaru dolaru commented Oct 31, 2023

This adds the missing scores parameter that was introduced in v8.9.0.

Docs say:

(Optional, array) Vocabulary value scores used by sentence-piece tokenization. Must have the same length as vocabulary. Required for unigram sentence-piece tokenized models like XLMRoberta and T5.

@dolaru dolaru self-assigned this Oct 31, 2023
@dolaru dolaru requested review from a team as code owners October 31, 2023 11:18
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dolaru
Copy link
Member Author

dolaru commented Oct 31, 2023

Closing as the Validate API check is not working with forks. 😭
Reopened from a branch in elastic/elasticsearch-specification in #2321.

@dolaru dolaru closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants