Fix ScoreFunction: variants are optional #257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
weight
function score is not exactly a function type even if documented as such, but a property common to all function types. Nowweight
can also be used standalone, meaning that aScoreFunction
union can exist without an actual function being set, and is valid with theweight
property set.This PR allows the
ScoreFunction
union to be built without choosing a variant, and also removes the unnecessary parentScoreFunction
parent class (see elastic/elasticsearch-specification#1666).Fixes #144, fixes #113, fixes #86