-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: support for "skip-ci" github label in order to reduce what to run #711
Conversation
/test |
this will avoid the notification regarding the google storage
@@ -145,6 +153,10 @@ pipeline { | |||
} | |||
post { | |||
always { | |||
// IMPORTANT: notify a build status in order to avoid GitHub checks with a wrong status. | |||
whenTrue(matchesPrLabel(label: 'skip-ci')) { | |||
error 'Pull Request has been configured to be disabled when there is a skip-ci label match' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, is not possible to report it as skipped instead of errord?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @mtojek |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hold on folks, why is it necessary? What's the issue we're trying to solve?
I see now, thanks for pointing it out, Victor. I believe that in the case of the Add GCP test package the problem is that we're waiting for the release v8.0.1, which should happen really soon. I wouldn't like to consider it as a justification to disable all tests, including successful ones. If this is the only reason why we need this PR, I would be for not merging it. |
What
skip-ci
label will only run the linting stage and then will stop doing anything else.Why
See the below use case:
Issue
Similar to elastic/beats#21377
UX
See the below comment that points to the reason for the failure: