Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore deprecated release tag from manifests #647

Merged
merged 11 commits into from
Feb 11, 2022
Merged

Ignore deprecated release tag from manifests #647

merged 11 commits into from
Feb 11, 2022

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Jan 14, 2022 •
edited
Loading

Stop showing information about the release tag of packages, to be deprecated in elastic/package-spec#256.

Use the prerelease parameter when searching for packages, related to elastic/package-registry#785.

Part of elastic/package-spec#225

@jsoriano jsoriano added the Team:Ecosystem Label for the Packages Ecosystem team label Jan 14, 2022
@jsoriano jsoriano self-assigned this Jan 14, 2022
@jsoriano jsoriano marked this pull request as draft January 14, 2022 17:10
jsoriano
jsoriano commented Jan 14, 2022
View reviewed changes
go.mod Outdated
@@ -145,3 +145,5 @@ require (
sigs.k8s.io/structured-merge-diff/v4 v4.1.2 // indirect
sigs.k8s.io/yaml v1.2.0 // indirect
)

replace github.com/elastic/package-spec v1.3.0 => github.com/jsoriano/package-spec v0.0.0-20220112095620-98e0d531845d
Copy link
Member Author

@jsoriano jsoriano Jan 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change won't be included.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that this PR is blocked on the other one: elastic/package-spec#256?

@jsoriano jsoriano mentioned this pull request Jan 14, 2022
Closed
14 tasks
@jsoriano jsoriano force-pushed the release-deprecation branch from bc49663 to 5cf33c8 Compare January 14, 2022 17:23
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 14, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-11T09:50:19.252+0000

  • Duration: 27 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 525
Skipped 0
Total 525

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@jsoriano jsoriano force-pushed the release-deprecation branch from 5cf33c8 to b719f91 Compare January 14, 2022 18:15
@jsoriano jsoriano force-pushed the release-deprecation branch from b719f91 to 0d43aab Compare January 14, 2022 18:16
@jsoriano jsoriano marked this pull request as ready for review January 19, 2022 18:34
mtojek
mtojek reviewed Jan 24, 2022
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, just left questions about dependent issues.

go.mod Outdated
@@ -145,3 +145,5 @@ require (
sigs.k8s.io/structured-merge-diff/v4 v4.1.2 // indirect
sigs.k8s.io/yaml v1.2.0 // indirect
)

replace github.com/elastic/package-spec v1.3.0 => github.com/jsoriano/package-spec v0.0.0-20220112095620-98e0d531845d
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that this PR is blocked on the other one: elastic/package-spec#256?

internal/registry/revisions.go
@@ -19,9 +19,12 @@ import (

// SearchOptions specify the query parameters without the package name for the search API
type SearchOptions struct {
Experimental bool `url:"experimental"`
Prerelease bool `url:"prerelease"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... oh, and on the EPR release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think this will be the last piece to merge.

mtojek
mtojek approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but considering the order of other pull requests :)

@jsoriano jsoriano force-pushed the release-deprecation branch from efa3531 to 35868ba Compare February 3, 2022 16:29
@jsoriano jsoriano mentioned this pull request Feb 3, 2022
Closed
@jsoriano jsoriano mentioned this pull request Feb 8, 2022
Closed
@jsoriano
Copy link
Member Author

jsoriano commented Feb 8, 2022

Testing with integrations repo in elastic/integrations#2651

@jsoriano jsoriano force-pushed the release-deprecation branch from 6c6de82 to 21b91cb Compare February 10, 2022 10:57
@jsoriano
Copy link
Member Author

Added changes to implement in elastic-package status the same conventions for release labels than the ones decided for Kibana (elastic/kibana#122973).

@mtojek could you please take another look?

@jsoriano jsoriano requested a review from mtojek February 10, 2022 11:17
mtojek
mtojek approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsoriano
Copy link
Member Author

/test

@jsoriano jsoriano merged commit f661b6f into elastic:main Feb 11, 2022
@jsoriano jsoriano deleted the release-deprecation branch February 11, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees

@jsoriano jsoriano

Labels
Team:Ecosystem Label for the Packages Ecosystem team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoriano @elasticmachine @mtojek