Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactions): remove the option for pixelRatio with png snapshot #1431

Merged
merged 4 commits into from
Nov 17, 2021

Conversation

rshen91
Copy link
Contributor

@rshen91 rshen91 commented Oct 18, 2021

Summary

BREAKING CHANGE

The getPNGSnapshot function no longer has the option for pixelRatio.

Details

This should be in a release with another breaking change since this breaking change is pretty minor.

Issues

Closes #869

Checklist

  • All related issues have been linked (i.e. closes #123, fixes #123)
  • New public API exports have been added to packages/charts/src/index.ts
  • Unit tests have been added or updated to match the most common scenarios
  • The proper documentation and/or storybook story has been added or updated

Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, thanks!

@rshen91 rshen91 marked this pull request as ready for review November 8, 2021 14:04
@markov00 markov00 added the :interactions Interactions related issue label Nov 8, 2021
@rshen91 rshen91 merged commit eebb069 into elastic:master Nov 17, 2021
nickofthyme pushed a commit that referenced this pull request Nov 18, 2021
# [40.0.0](v39.0.2...v40.0.0) (2021-11-18)

### Bug Fixes

* **interactions:** remove the option for pixelRatio with png snapshot ([#1431](#1431)) ([eebb069](eebb069))
* **xy:** occlude points outside of y domain ([#1475](#1475)) ([3176f02](3176f02))

### Features

* **annotations:** add annotations to DebugState ([#1434](#1434)) ([c5ea600](c5ea600))
* **heatmap:** add valueShown in heatmap debug state ([#1460](#1460)) ([962e089](962e089))

### BREAKING CHANGES

* **interactions:** The getPNGSnapshot function no longer has an option for pixelRatio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change :interactions Interactions related issue :refactor Code refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getPNGSnapshot pixelRatio not used anymore
2 participants