Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(partition): remove width height from partition config #1377

Closed
wants to merge 2 commits into from

Conversation

rshen91
Copy link
Contributor

@rshen91 rshen91 commented Sep 13, 2021

Summary

Details

Issues

Closes #1185

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • The :theme label has been added and the @elastic/eui-design team has been pinged when there are Theme API changes
  • All related issues have been linked (i.e. closes #123, fixes #123)
  • New public API exports have been added to packages/charts/src/index.ts
  • Unit tests have been added or updated to match the most common scenarios
  • The proper documentation and/or storybook story has been added or updated
  • The code has been checked for cross-browser compatibility (Chrome, Firefox, Safari, Edge)
  • Visual changes have been tested with all available themes including dark, light, eui-dark & eui-light

@rshen91 rshen91 added :partition Partition/PieChart/Donut/Sunburst/Treemap chart related wip work in progress labels Sep 13, 2021
@rshen91
Copy link
Contributor Author

rshen91 commented Sep 14, 2021

In discussion with Nick - duplicating efforts closing

@rshen91 rshen91 closed this Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:partition Partition/PieChart/Donut/Sunburst/Treemap chart related wip work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partition chart should pull from theme and spec not config
1 participant