fix(brush): force brush tool per panel #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickofthyme
approved these changes
Mar 10, 2021
Comment on lines
+113
to
125
| export function getBrushForXAxis( | ||
| chartRotation: Rotation, | ||
| { hPanelStart, vPanelStart, hPanelWidth, vPanelHeight, start, end }: PanelPoints, | ||
| ) { | ||
| const rotated = isVerticalRotation(chartRotation); | ||
|
|
||
| return { | ||
| left: getLeftPoint(chartDimensions, start), | ||
| top: getTopPoint(chartDimensions, start), | ||
| height: getMinimalHeight(start, end), | ||
| width: getMinimalWidth(start, end), | ||
| left: rotated ? hPanelStart : start.x, | ||
| top: rotated ? start.y : vPanelStart, | ||
| height: rotated ? getMinSize(start.y, end.y) : vPanelHeight, | ||
| width: rotated ? hPanelWidth : getMinSize(start.x, end.x), | ||
| }; | ||
| } |
There was a problem hiding this comment.
These diffs are horribly misaligned 🙄 ....git 😞
There was a problem hiding this comment.
I know, I've refactored a bit the code cleaning up it a bit, but the diff is a bit messy, better to check both file side by side
There was a problem hiding this comment.
This might just be me misunderstanding, but is the brush area adjusting for height less than the height of the panel?
Codecov Report
@@ Coverage Diff @@
## master #1071 +/- ##
==========================================
+ Coverage 72.47% 73.09% +0.61%
==========================================
Files 366 383 +17
Lines 11361 11726 +365
Branches 2472 2527 +55
==========================================
+ Hits 8234 8571 +337
- Misses 3112 3132 +20
- Partials 15 23 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
markov00
added a commit
to markov00/elastic-charts
that referenced
this pull request
Mar 11, 2021
This commit force the brush tool to work per panel when using small multiples. This behavior is built to works independently from the presence or absence of a small multiples configuration. It works by forcing the brushable area to be constraint between the boundaries of the panel where the brushing event started. The brush selection doesn't move between panels and the coordinate of the mouse down event determines the limiting panel. fix elastic#1070
markov00
added a commit
that referenced
this pull request
Mar 11, 2021
This commit force the brush tool to work per panel when using small multiples. This behavior is built to works independently from the presence or absence of a small multiples configuration. It works by forcing the brushable area to be constraint between the boundaries of the panel where the brushing event started. The brush selection doesn't move between panels and the coordinate of the mouse down event determines the limiting panel. fix #1070
|
🎉 This PR is included in version 25.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [25.3.0](elastic/elastic-charts@v25.2.0...v25.3.0) (2021-03-11) ### Bug Fixes * **brush:** force brush tool per panel ([opensearch-project#1071](elastic/elastic-charts#1071)) ([61d6b7a](elastic/elastic-charts@61d6b7a)), closes [opensearch-project#1070](elastic/elastic-charts#1070) ### Features * debug state for the heatmap chart ([opensearch-project#976](elastic/elastic-charts#976)) ([9ba7666](elastic/elastic-charts@9ba7666))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR forced the brush tool to work per panel when using small multiples. This behavior is built to works independently from the presence or absence of a small multiples configuration.
It works by forcing the brushable area to be constraint between the boundaries of the panel where the brushing event started. The brush selection doesn't move between panels and the coordinate of the mouse down event determines the limiting panel.
I've cleaned up the code to compute the brush area and also updated the unit test by mocking the SmallMultiple specs
fixes #1070
Mar-11-2021.13-28-00.mp4