Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bar chart] tooltips longer than the page height cause page to jump #1576

Closed
mbondyra opened this issue Jan 31, 2022 · 2 comments · Fixed by #1782
Closed

[Bar chart] tooltips longer than the page height cause page to jump #1576

mbondyra opened this issue Jan 31, 2022 · 2 comments · Fixed by #1782
Labels
:all Applies to all chart types bug Something isn't working :tooltip Related to hover tooltip

Comments

@mbondyra
Copy link
Contributor

Describe the issue
Here's the bug raised in Lens: elastic/kibana#122782
When a tooltip is longer than the page, the scroll keeps appearing and disappearing in certain positions:
Jan-31-2022 13-58-13

Here's the reproducible sandbox (the buggy versions are 35.0.0+)
https://codesandbox.io/s/jumpingscroll-35-0-w6sup

Here's the 34.2.1 version, the working one:
https://codesandbox.io/s/jumpingscroll-34-2-g256r

@mbondyra mbondyra added the bug Something isn't working label Jan 31, 2022
@mbondyra mbondyra changed the title [Bar chart] tooltips that are longer than the page height make page to jump [Bar chart] tooltips longer than the page height cause page to jump Jan 31, 2022
@markov00
Copy link
Member

this will be fixed with #615

@markov00 markov00 added :all Applies to all chart types :tooltip Related to hover tooltip labels Feb 28, 2022
@markov00
Copy link
Member

@mbondyra I've tested the example you mentioned working but it doesn't seem to work to me.

With the new tooltip redesign, this bug will be fixed, but we can't fix it with the current version because this problem depends on the style applied to the body. The tooltip DOM is attached to the body so if the body overflow prop is auto/default then the page will scroll and we can't do much (I actually don't have ideas, I really like to avoid testing for the tooltip size to reducing it size depending on the window before rendering it first because this is expensive, second because it is an edge case, third because it can be fixed by the application using the chart itself, and finally because this will be fixed in the near future with the new tooltip design

@nickofthyme nickofthyme linked a pull request Aug 25, 2022 that will close this issue
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:all Applies to all chart types bug Something isn't working :tooltip Related to hover tooltip
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants