Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .go-version to match go.mod #6723

Closed
wants to merge 1 commit into from

Conversation

belimawr
Copy link
Contributor

@belimawr belimawr commented Feb 5, 2025

What does this PR do?

see title

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@belimawr belimawr added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Feb 5, 2025
@belimawr belimawr requested a review from a team as a code owner February 5, 2025 22:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link
Contributor

mergify bot commented Feb 5, 2025

This pull request does not have a backport label. Could you fix it @belimawr? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@belimawr belimawr added skip-changelog backport-active-8 Automated backport with mergify to all the active 8.[0-9]+ branches labels Feb 5, 2025
Copy link
Member

@AndersonQ AndersonQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's what we want to do to fix the build system using the host's mod cache.

Let's discuss more with the team.

@belimawr
Copy link
Contributor Author

belimawr commented Feb 6, 2025

buildkite test this

@belimawr
Copy link
Contributor Author

belimawr commented Feb 6, 2025

I don't think it's what we want to do to fix the build system using the host's mod cache.

Let's discuss more with the team.

While I agree with you on a long-term solution, we should merge a quick fix to unblock main.

@belimawr
Copy link
Contributor Author

belimawr commented Feb 6, 2025

I've just realised docker.elastic.co/beats-dev/golang-crossbuild:1.22.11-main-debian11 is not available yet 🤦‍♂️

Maybe we should revert #6663.

I'm also puzzled how it passed on CI.

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@belimawr
Copy link
Contributor Author

belimawr commented Feb 7, 2025

Closing because this issue is already addressed by #6700

@belimawr belimawr closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-active-8 Automated backport with mergify to all the active 8.[0-9]+ branches skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants