-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[k8s] Fix System Integration to utilise hostfs mounts #6666
[k8s] Fix System Integration to utilise hostfs mounts #6666
Conversation
9a1ab37
to
295e36b
Compare
31b7f6c
to
18d4de5
Compare
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
This is also broken in https://github.com/elastic/elastic-agent/blob/main/deploy/kubernetes/elastic-agent-standalone-kubernetes.yaml, are we tracking that as a separate issue? Would probably be simplest to fix both at the same time. |
Shouldn't we also backport this on 9.0 branch? |
|
* [helm]: fix system integration to utilise hostfs mount * [kustomize]: fix system integration to utilise hostfs mount --------- Co-authored-by: Julien Lind <julien.lind@elastic.co> (cherry picked from commit 45b0cf4)
* [helm]: fix system integration to utilise hostfs mount * [kustomize]: fix system integration to utilise hostfs mount --------- Co-authored-by: Julien Lind <julien.lind@elastic.co> (cherry picked from commit 45b0cf4)
* [helm]: fix system integration to utilise hostfs mount * [kustomize]: fix system integration to utilise hostfs mount --------- Co-authored-by: Julien Lind <julien.lind@elastic.co> (cherry picked from commit 45b0cf4)
* [helm]: fix system integration to utilise hostfs mount * [kustomize]: fix system integration to utilise hostfs mount --------- Co-authored-by: Julien Lind <julien.lind@elastic.co> (cherry picked from commit 45b0cf4)
* [helm]: fix system integration to utilise hostfs mount * [kustomize]: fix system integration to utilise hostfs mount --------- Co-authored-by: Julien Lind <julien.lind@elastic.co> (cherry picked from commit 45b0cf4) Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
* [helm]: fix system integration to utilise hostfs mount * [kustomize]: fix system integration to utilise hostfs mount --------- Co-authored-by: Julien Lind <julien.lind@elastic.co> (cherry picked from commit 45b0cf4) Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
* [helm]: fix system integration to utilise hostfs mount * [kustomize]: fix system integration to utilise hostfs mount --------- Co-authored-by: Julien Lind <julien.lind@elastic.co> (cherry picked from commit 45b0cf4) Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
* [helm]: fix system integration to utilise hostfs mount * [kustomize]: fix system integration to utilise hostfs mount --------- Co-authored-by: Julien Lind <julien.lind@elastic.co> (cherry picked from commit 45b0cf4) Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
What does this PR do?
This PR ensures that the Elastic Agent system integration correctly utilizes the
/hostfs
mount to collect host-level metrics. Previously, the system integration only monitored processes visible within the container due to missing configuration settings for the/hostfs
path.The changes include:
system.hostfs: /hostfs
to all relevant system metricsets in both the Helm Chart templates and rendered manifests.Why is it important?
Without this fix, the Elastic Agent system integration collects only container-level metrics instead of full host-level metrics. This leads to incomplete observability of the Kubernetes nodes and limits visibility into host performance and resource utilization.
By explicitly setting
system.hostfs: /hostfs
, the agent can correctly access host-level/proc
and/sys
files, ensuring comprehensive monitoring.Checklist
./changelog/fragments
using the changelog tool.Disruptive User Impact
This change does not introduce breaking changes, as it only enhances system integration behavior without modifying existing user configurations. However, users who previously relied on container-only monitoring should be aware that host-level metrics will now be collected.
How to test this PR locally
/proc
and/sys
are mounted under/hostfs
inside the container.Related issues
Questions to ask yourself