Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.17](backport #6360) [k8s] add kubernetes hints integration tests #6388

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 18, 2024

What does this PR do?

This is the last part (I promise) of the PR series to add support for Kubernetes hints and integration tests for Redis. It introduces:

  • Additional test cases to validate agent Kubernetes hints functionality using Redis as the hints-enabled workload:
    • When hints-enabled workloads pre-exist the agent deployment.
    • When hints-enabled workloads are deployed after the agent is already running.

Why is it important?

This PR completes the Kubernetes hints-based testing and it ensures that that Kubernetes hints functionality is thoroughly tested.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an integration test or an E2E test

Disruptive User Impact

There is no expected disruption for users as this PR only extends k8s integration tests.

How to test this PR locally

mage integration:auth
PLATFORMS=linux/arm64 EXTERNAL=true SNAPSHOT=true PACKAGES=docker mage -v package 
INSTANCE_PROVISIONER=kind STACK_PROVISIONER=stateful K8S_VERSION=v1.31.1 SNAPSHOT=true mage integration:kubernetes

Related issues


This is an automatic backport of pull request #6360 done by [Mergify](https://mergify.com).

@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Dec 18, 2024
@mergify mergify bot requested a review from a team as a code owner December 18, 2024 16:58
@mergify mergify bot requested review from michalpristas and andrzej-stencel and removed request for a team December 18, 2024 16:58
Copy link
Contributor Author

mergify bot commented Dec 18, 2024

Cherry-pick of c7c5ba4 has failed:

On branch mergify/bp/8.17/pr-6360
Your branch is up to date with 'origin/8.17'.

You are currently cherry-picking commit c7c5ba413.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   testing/integration/testdata/k8s.hints.redis.yaml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   testing/integration/kubernetes_agent_standalone_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@pkoutsovasilis
Copy link
Contributor

requires this PR to be merged first

* feat: add kubernetes hints test

* feat: utilise labelselector for checking redis pods

* feat: check redis pods for correct hint annotations

(cherry picked from commit c7c5ba4)

# Conflicts:
#	testing/integration/kubernetes_agent_standalone_test.go
@pkoutsovasilis pkoutsovasilis force-pushed the mergify/bp/8.17/pr-6360 branch from d5079b2 to dbba6b8 Compare December 19, 2024 22:40
Copy link

@pkoutsovasilis pkoutsovasilis merged commit 739ad41 into 8.17 Dec 20, 2024
14 checks passed
@pkoutsovasilis pkoutsovasilis deleted the mergify/bp/8.17/pr-6360 branch December 20, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant