Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[helm] remove unsupported Release fields for publishing the chart as EKS addon #6079

Merged
merged 2 commits into from
Nov 20, 2024
Merged

[helm] remove unsupported Release fields for publishing the chart as EKS addon #6079

merged 2 commits into from
Nov 20, 2024

Conversation

pkoutsovasilis
Copy link
Contributor

@pkoutsovasilis pkoutsovasilis commented Nov 19, 2024 •
edited
Loading

What does this PR do?

This PR removes unsupported fields Release.IsInstall, Release.IsUpgrade, and .Release.Service from the Helm chart. These fields are unavailable in the EKS addon and their presence leads to Helm chart validation failures when using the AWS console. The changes ensure compatibility with EKS addon requirements by refactoring the chart to exclude these fields.

Why is it important?

This change is crucial for ensuring that the Helm chart used in the Elastic Agent EKS addon passes AWS console validations. Unsupported fields prevent us from publishing this Helm chart as an EKS addon.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

This PR should not cause any direct disruption to users, but it will ensure smoother integration and deployment in AWS EKS environments.

How to test this PR locally

  1. Try to publish the packaged Helm chart as an EKS add-on and you will see no validation errors 🙂

Related issues

@pkoutsovasilis pkoutsovasilis added enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify labels Nov 19, 2024
@pkoutsovasilis pkoutsovasilis self-assigned this Nov 19, 2024
@pkoutsovasilis pkoutsovasilis marked this pull request as ready for review November 19, 2024 15:17
@pkoutsovasilis pkoutsovasilis requested a review from a team as a code owner November 19, 2024 15:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

blakerouse
blakerouse approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2 for removals!

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pkoutsovasilis pkoutsovasilis merged commit 5cd2518 into elastic:main Nov 20, 2024
9 checks passed
@pkoutsovasilis pkoutsovasilis deleted the helm/remove_release_fields branch November 20, 2024 12:21
mergify bot pushed a commit that referenced this pull request Nov 20, 2024
@pkoutsovasilis @mergify
[helm] remove unsupported Release fields for publishing the chart as …
9384725 
…an EKS addon (#6079)

(cherry picked from commit 5cd2518)

# Conflicts:
#	deploy/helm/elastic-agent/examples/eck/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/fleet-managed/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/kubernetes-default/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/kubernetes-hints-autodiscover/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/kubernetes-only-logs/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/multiple-integrations/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/nginx-custom-integration/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/system-custom-auth-paths/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/user-cluster-role/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/user-service-account/rendered/manifest.yaml
@mergify mergify bot mentioned this pull request Nov 20, 2024
Merged
7 tasks
mergify bot pushed a commit that referenced this pull request Nov 20, 2024
@pkoutsovasilis @mergify
[helm] remove unsupported Release fields for publishing the chart as …
4855657 
…an EKS addon (#6079)

(cherry picked from commit 5cd2518)

# Conflicts:
#	deploy/helm/elastic-agent/examples/eck/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/fleet-managed/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/kubernetes-default/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/kubernetes-hints-autodiscover/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/kubernetes-only-logs/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/multiple-integrations/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/nginx-custom-integration/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/system-custom-auth-paths/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/user-cluster-role/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/user-service-account/rendered/manifest.yaml
@mergify mergify bot mentioned this pull request Nov 20, 2024
Merged
7 tasks
pkoutsovasilis added a commit that referenced this pull request Nov 20, 2024
@mergify @pkoutsovasilis
[8.x](backport #6079) [helm] remove unsupported Release fields for pu…
8877535 
…blishing the chart as EKS addon (#6094)

* [helm] remove unsupported Release fields for publishing the chart as an EKS addon (#6079)

(cherry picked from commit 5cd2518)

# Conflicts:
#	deploy/helm/elastic-agent/examples/eck/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/fleet-managed/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/kubernetes-default/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/kubernetes-hints-autodiscover/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/kubernetes-only-logs/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/multiple-integrations/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/nginx-custom-integration/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/system-custom-auth-paths/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/user-cluster-role/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/user-service-account/rendered/manifest.yaml

* fix: resolve conflicts

---------

Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
pkoutsovasilis added a commit that referenced this pull request Nov 20, 2024
@mergify @pkoutsovasilis
[8.16](backport #6079) [helm] remove unsupported Release fields for p…
730233b 
…ublishing the chart as EKS addon (#6093)

* [helm] remove unsupported Release fields for publishing the chart as an EKS addon (#6079)

(cherry picked from commit 5cd2518)

# Conflicts:
#	deploy/helm/elastic-agent/examples/eck/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/fleet-managed/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/kubernetes-default/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/kubernetes-hints-autodiscover/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/kubernetes-only-logs/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/multiple-integrations/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/nginx-custom-integration/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/system-custom-auth-paths/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/user-cluster-role/rendered/manifest.yaml
#	deploy/helm/elastic-agent/examples/user-service-account/rendered/manifest.yaml

* fix: resolve conflicts

---------

Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

@michalpristas michalpristas Awaiting requested review from michalpristas michalpristas is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@pkoutsovasilis pkoutsovasilis

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify enhancement New feature or request skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[helm] Remove Unsupported Release Fields from Helm Chart for EKS Addon Compatibility
3 participants
@pkoutsovasilis @elasticmachine @blakerouse