[helm] add lint checks for renderExamples #6060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
andrzej-stencel
approved these changes
Nov 19, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
* fix: add lint checks for renderExamples * fix: helm linting errors (cherry picked from commit 0097d21)
mergify bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
* fix: add lint checks for renderExamples * fix: helm linting errors (cherry picked from commit 0097d21)
This was referenced Nov 20, 2024
pkoutsovasilis
added a commit
that referenced
this pull request
Nov 20, 2024
pkoutsovasilis
added a commit
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR extends the Helm lint checks in our CI pipeline to validate all examples in the Helm chart. Previously, the
helm templatecommand passed successfully but was insufficient becausehelm lintcould still fail. By ensuring comprehensive linting, we address inconsistencies and prevent errors during deployment.Key changes include:
Why is it important?
This change is important to ensure consistency across our Helm chart configurations. By extending the lint checks to include all examples, we can catch issues ( such as the ones seen in this Buildkite job) early in the CI pipeline, reducing the risk of deployment failures.
Checklist
./changelog/fragmentsusing the changelog toolDisruptive User Impact
This change does not introduce any disruptive impact on users. The enhancements are internal to the CI validation process and do not affect end-user experience directly.
How to test this PR locally
helm template ./deploy/helm/elastic-agent -f ./deploy/helm/elastic-agent/examples/kubernetes-default/agent-kubernetes-values.yamlto ensure it passes.helm lint ./deploy/helm/elastic-agent -f ./deploy/helm/elastic-agent/examples/kubernetes-default/agent-kubernetes-values.yamland confirm that the lint checks also pass without errors.mage helm:renderExamplesdoes lint validation for all examples as wellRelated issues