Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm] add envFrom in agent preset #5992

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

pkoutsovasilis
Copy link
Contributor

@pkoutsovasilis pkoutsovasilis commented Nov 11, 2024

What does this PR do?

This PR adds support for specifying envFrom in the pod template of the Helm chart. By introducing this feature, users can configure environment variables from ConfigMaps or Secrets more flexibly and efficiently. The change modifies the pod template to include a new section that allows injecting envFrom values, providing an enhanced way to handle environment settings.

Why is it important?

This enhancement is useful for users who need to manage environment variables dynamically through ConfigMaps or Secrets e.g. through ExternalSecrets.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

N/A

How to test this PR locally

  1. create a k8s secret with the name $secretName
  2. follow the kubernetes example and add this param --set 'agent.presets.perNode.envFrom[0].secretRef.name'=$secretName

Related issues

N/A

@pkoutsovasilis pkoutsovasilis added enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify labels Nov 11, 2024
@pkoutsovasilis pkoutsovasilis self-assigned this Nov 11, 2024
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pkoutsovasilis pkoutsovasilis marked this pull request as ready for review November 11, 2024 18:10
@pkoutsovasilis pkoutsovasilis requested a review from a team as a code owner November 11, 2024 18:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@pkoutsovasilis pkoutsovasilis merged commit 9396e19 into elastic:main Nov 12, 2024
14 checks passed
@pkoutsovasilis pkoutsovasilis deleted the helm/pod_env_from branch November 12, 2024 14:18
mergify bot pushed a commit that referenced this pull request Nov 12, 2024
mergify bot pushed a commit that referenced this pull request Nov 12, 2024
pkoutsovasilis added a commit that referenced this pull request Nov 12, 2024
(cherry picked from commit 9396e19)

Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
pkoutsovasilis added a commit that referenced this pull request Nov 12, 2024
(cherry picked from commit 9396e19)

Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify enhancement New feature or request skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants