-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[helm] add envFrom in agent preset #5992
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
swiatekm
approved these changes
Nov 12, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
(cherry picked from commit 9396e19)
mergify bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
(cherry picked from commit 9396e19)
This was referenced Nov 12, 2024
pkoutsovasilis
added a commit
that referenced
this pull request
Nov 12, 2024
pkoutsovasilis
added a commit
that referenced
this pull request
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-8.x
Automated backport to the 8.x branch with mergify
backport-8.16
Automated backport with mergify
enhancement
New feature or request
skip-changelog
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for specifying
envFrom
in the pod template of the Helm chart. By introducing this feature, users can configure environment variables from ConfigMaps or Secrets more flexibly and efficiently. The change modifies the pod template to include a new section that allows injectingenvFrom
values, providing an enhanced way to handle environment settings.Why is it important?
This enhancement is useful for users who need to manage environment variables dynamically through ConfigMaps or Secrets e.g. through ExternalSecrets.
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
N/A
How to test this PR locally
$secretName
--set 'agent.presets.perNode.envFrom[0].secretRef.name'=$secretName
Related issues
N/A