-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.16](backport #5950) [proxytest] Wait all requests to finish before closing the server #5970
Conversation
Cherry-pick of e423d73 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This pull request has not been merged yet. Could you please review and merge it @AndersonQ? 🙏 |
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request has not been merged yet. Could you please review and merge it @AndersonQ? 🙏 |
85e326d
to
09146f0
Compare
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
This pull request has not been merged yet. Could you please review and merge it @AndersonQ? 🙏 |
1 similar comment
This pull request has not been merged yet. Could you please review and merge it @AndersonQ? 🙏 |
|
What does this PR do?
Makes the proxytest to wait all requests to finish before closing the underlying HTTP server
Why is it important?
The request log sometimes happens after the tests has finished, what causes the test to panic
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragments
using the changelog tool[ ] I have added an integration test or an E2E testDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself
This is an automatic backport of pull request #5950 done by [Mergify](https://mergify.com).