Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #5911) Ignore env.sh generated by mage integration:*EnvFile #5913

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 1, 2024

What does this PR do?

Ignores the env.sh generated by mage integration:*EnvFile

Why is it important?

to avoid cloud credentials to be committed by mistake

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Disruptive User Impact

  • N/A

How to test this PR locally

Run either

mage integration:generateEnvFile
mage integration:deployEnvFile

check git status

git status

it hsould not show env.sh as a new untracked file

Related issues

  • N/A

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

This is an automatic backport of pull request #5911 done by [Mergify](https://mergify.com).

@mergify mergify bot added the backport label Nov 1, 2024
@mergify mergify bot requested a review from a team as a code owner November 1, 2024 11:24
@mergify mergify bot requested review from kaanyalti and andrzej-stencel and removed request for a team November 1, 2024 11:24
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@AndersonQ AndersonQ requested review from AndersonQ and removed request for kaanyalti and andrzej-stencel November 1, 2024 15:30
@AndersonQ AndersonQ merged commit bdc819a into 8.x Nov 1, 2024
10 checks passed
@AndersonQ AndersonQ deleted the mergify/bp/8.x/pr-5911 branch November 1, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant