[8.x](backport #5745) Diagnostics file writes use RedactSecretPaths #5798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Diagnostics file writes use RedactSecretPaths * Add integration test * Change to yaml.v3 in integration tests * revert update to yaml.v3 across other testing files (cherry picked from commit 1f3ade3)
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
|
@ycombinator I think this one will need to be manually forced |
pierrehilbert
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The elastic-agent will use redact secret paths in files written in diagnostics bundles. Secret paths are expected to be specified as a top-level attribute in yaml data being written.
Why is it important?
Secrets that the fleet-server injects into policies can appear in diagnostics bundles.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog toolDisruptive User Impact
Secrets in diagnostics bundles will be redacted, as our public documentation discloses.
How to test this PR locally
Enrol in a fleet policy with secrets and collect a diagnostics bundle.
This is an automatic backport of pull request #5745 done by Mergify.